build-push-action icon indicating copy to clipboard operation
build-push-action copied to clipboard

Update Readme and description with push on Docker hub

Open SivaKesava1 opened this issue 5 years ago • 13 comments

Currently, if we use the Github action with this repo, the image is built and pushed to the Docker hub, but the Readme and description are not updated on the Docker hub webpage. It would be nice to have this in the future to use this action and altogether disable auto build.

SivaKesava1 avatar Mar 23 '20 19:03 SivaKesava1

Hi @SivaKesava1. We want to take a look at matching functionality with auto-builds so this is great feedback. Any thoughts @nebuk89?

zappy-shu avatar Mar 23 '20 22:03 zappy-shu

By the way, I've been using https://github.com/marketplace/actions/docker-hub-description to do that.

felipecrs avatar May 12 '20 19:05 felipecrs

Here's another github action that can set/update the container repo description from the README in the github repo. It supports container repos on Docker Hub, Harbor v2 and Quay.

For Dockerhub it's possible to set both the short description and the full description (README).

update-container-description

christian-korneck avatar Jul 12 '20 12:07 christian-korneck

@crazy-max and folks, can we re-open this to get this core capability as part of this official docker action? I'd rather use that than start piling up on third-party actions. Regardless of the community ecosystem around Docker related actions, I think this is a very core capability that I'd expect to have with this action.

lirantal avatar Jun 27 '21 16:06 lirantal

@lirantal +1 for this. For the meantime, I created a Docker CLI plugin and a github action based on it to fill this gap. Feel free to open an issue if you feel it doesn't serve your needs. (Yes, it's an additional action/job step ... but github actions is all about modularity imho).

christian-korneck avatar Jun 27 '21 16:06 christian-korneck

Thanks!

Maybe it's worth to ping @peter-evans and ask if they'd like to contribute a pull request that adds this capability to this official action?

lirantal avatar Jun 27 '21 17:06 lirantal

We will work on this. Keep you in touch! (cc @technicallyjosh)

@lirantal Some changes may be required to allow a PAT to modify the README on Docker Hub. ATM only username/password credentials work.

crazy-max avatar Jun 27 '21 17:06 crazy-max

Did the team ever got around fixing this?

whizzzkid avatar Dec 16 '22 21:12 whizzzkid

@whizzzkid Did the team ever got around fixing this?

yes, it's now possible to set the repo description when authenticated with a PAT (was fixed earlier this year, there was another github issue about it that I can't seem to find at the moment). (Thanks to anyone from the Docker Hub team involved with this!)

christian-korneck avatar Dec 16 '22 21:12 christian-korneck

the documentation using the third party action is available here: https://docs.docker.com/build/ci/github-actions/examples/#update-docker-hub-repository-description

but this issue is open to add that functionality into this action, correct?

djbrown avatar Jan 10 '23 18:01 djbrown

+1, pushing updates to the Docker Hub README should 100% be part of the core functionality.

srstsavage avatar Mar 06 '23 17:03 srstsavage

@djbrown link is broken, for the next ones coming here to find the link. here it is:

https://docs.docker.com/build/ci/github-actions/update-dockerhub-desc/

Alw3ys avatar Apr 22 '23 13:04 Alw3ys

Seems this one went a bit under the radar for too long 😅. Should be an easy PR to pop in. Will work on this week to include repo description to update.

Edit: So after discussing with @crazy-max, we believe the best way forward is to keep the updating of the description in a separate action as this action is fully revolved around Buildx. We have some ideas to make this a bit easier with reusing the same bearer token obtained from login though. Some PRs are gonna come to make smaller quality of life improvements.

technicallyjosh avatar May 17 '23 03:05 technicallyjosh

@technicallyjosh @crazy-max Can you please give us a link to the new issue you're working with, so we can follow the work there?

Thank you!

baruchiro avatar Mar 10 '24 08:03 baruchiro