build-push-action icon indicating copy to clipboard operation
build-push-action copied to clipboard

Support Windows image builds

Open sixeyed opened this issue 4 years ago • 12 comments

The GitHub runner windows-2019 has Docker installed, so you can build and push images with a workflow like this:

  • https://github.com/sixeyed/pi/blob/master/.github/workflows/build-windows.yaml

Would be great if this action supported Windows image builds on Windows runners.

sixeyed avatar Mar 23 '20 10:03 sixeyed

Hi @sixeyed, thanks for your feedback. This is interesting and I can see it being useful. Currently the action runs using a Linux container hence it wouldn't work with the Windows hosts so this will need some investigating on the best way to support this. I will discuss this with our PM and see if we can get it prioritized

zappy-shu avatar Mar 23 '20 10:03 zappy-shu

FYI this is working with Windows https://github.com/mr-smithers-excellent/docker-build-push but hitting some issues on second push.

We have Linux images and Windows based images (for On prem customers).

adamgins avatar May 18 '20 07:05 adamgins

I worked several days to build a Windows image locally with all our stack (C++/Qt based application) only to find out I could not build and use the final image with an action. Sad 😄

giallu avatar Nov 11 '21 23:11 giallu

I would also be interested in this action working on Windows.

rshamsnejad avatar Nov 14 '21 21:11 rshamsnejad

I am also interested in this action working on Windows.

Antonytm avatar Feb 16 '22 19:02 Antonytm

Are there any plans to have this action work on windows too?

ScottGuymer avatar Mar 01 '22 08:03 ScottGuymer

Hey folks, just to add traction here, we would also benefit from having this action working on Windows. Is there any way folks outside of Docker (like myself) can contribute to do this?

ian-flores avatar Jun 27 '22 18:06 ian-flores

@ian-flores I ended up with the usage mr-smithers-excellent/docker-build-push@v5 action template.

Antonytm avatar Jun 27 '22 19:06 Antonytm

Will this be implemented in the near future?

bkalcho avatar Dec 15 '22 14:12 bkalcho

As of last week, buildkit master can build basic Windows images. But it might take a while for tests, releases, buildx/actions-toolkit integration, and availability in GitHub hosted runners. Partially tracked in moby/buildkit#616

pl4nty avatar Oct 25 '23 10:10 pl4nty