build-push-action icon indicating copy to clipboard operation
build-push-action copied to clipboard

v6 cannot be used with actions/download-artifact@v4

Open kateinoigakukun opened this issue 1 year ago • 8 comments

Contributing guidelines

I've found a bug, and:

  • [X] The documentation does not mention anything about my problem
  • [X] There are no open or closed issues that are related to my problem

Description

After updating docker/build-push-action to v6, we started observing the following error at actions/download-artifact step.

Unable to download artifact(s): Unable to download and extract artifact: Artifact download failed after 5 retries.

I guess something in the build summary uploading feature is incompatible with actions/download-artifact.

You can reproduce the problem with this https://github.com/kateinoigakukun/gh-actions-sandbox/actions/runs/9737812232/workflow

Expected behaviour

actions/download-artifact can download all artifacts even with this action.

Actual behaviour

actions/download-artifact fails while trying to download all artifacts

Repository URL

No response

Workflow run URL

No response

YAML workflow

name: Docker Build

on:
  workflow_dispatch:

jobs:
  docker:
    runs-on: ubuntu-latest
    steps:
      - uses: docker/build-push-action@v6
  post-job:
    runs-on: ubuntu-latest
    needs: [docker]
    steps:
      - uses: actions/download-artifact@v4

Workflow logs

No response

BuildKit logs

No response

Additional info

No response

kateinoigakukun avatar Jul 01 '24 03:07 kateinoigakukun

Thanks for making a pull request to jupyterlab! To try out this branch on binder, follow this link: Binder

jupyterlab-probot[bot] avatar Jun 19 '24 09:06 jupyterlab-probot[bot]

So the failure here is interesting case of CI pulling both the released and dev version. We may want to merge this and do an immediate patch release to fix CI:

ERROR: Cannot install jupyterlab and jupyterlab[upgrade-extension]==4.2.2 because these package versions have conflicting dependencies.

The conflict is caused by:
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
    jupyterlab[upgrade-extension] 4.2.2 depends on pydantic<2.0; extra == "upgrade-extension"
    copier 9.2.0 depends on pydantic>=2.4.2
    jupyterlab[upgrade-extension] 4.2.2 depends on pydantic<2.0; extra == "upgrade-extension"
    copier 9.1.1 depends on pydantic>=2.4.2
    jupyterlab[upgrade-extension] 4.2.2 depends on pydantic<2.0; extra == "upgrade-extension"
    copier 9.1.0 depends on pydantic>=2.4.2
    jupyterlab[upgrade-extension] 4.2.2 depends on pydantic<2.0; extra == "upgrade-extension"
    copier 9.0.1 depends on pydantic>=2.4.2

krassowski avatar Jun 19 '24 10:06 krassowski