actions-setup-docker icon indicating copy to clipboard operation
actions-setup-docker copied to clipboard

increase timeout for docker start

Open better0fdead opened this issue 2 years ago • 10 comments

Increased timeout for docker start from 180s to 600s. Have done it because sometimes 180s is not enough for github macOs runners. E.g run, run.

better0fdead avatar Apr 27 '23 12:04 better0fdead

cc @00Kai0 @junchen1992 @khs1994

Would be nice to have this merged, I'm hitting the same issue.

calm-mlin avatar Nov 08 '23 00:11 calm-mlin

Yep, same issue. Also reported in: https://github.com/docker-practice/actions-setup-docker/issues/34 and: https://github.com/docker-practice/actions-setup-docker/issues/24

diegorondini avatar Dec 01 '23 11:12 diegorondini

Please merge this, having same issue

limpbrains avatar Dec 04 '23 15:12 limpbrains

You can use this fix now with uses: better0fdead/actions-setup-docker@better0fdead/increase-timeout

stephenwade avatar Dec 26 '23 01:12 stephenwade

Many users would be happy with this merge 🙌🏼

anitacaron avatar Jan 15 '24 18:01 anitacaron

Probably even 300 would be enough. Often it takes just a bit more than 180 seconds:

 + '[' 184 -gt 600 ']'
+ /Applications/Docker.app/Contents/Resources/bin/docker system info
+ ((  i++ == 0  ))
+ printf .
+ command -v docker
./usr/local/bin/docker
+ sleep 1
+ '[' 185 -gt 600 ']'
+ /Applications/Docker.app/Contents/Resources/bin/docker system info
+ ((  i++ == 0  ))
+ printf .
+ command -v docker
./usr/local/bin/docker
+ sleep 1
+ '[' 186 -gt 600 ']'
+ /Applications/Docker.app/Contents/Resources/bin/docker system info
+ echo '::notice::-- Docker is ready.Wait time is 186 s'
+ uname -a
Notice: -- Docker is ready.Wait time is 186 s

diegorondini avatar Jan 18 '24 10:01 diegorondini

Very yes.

daniel-wong-dfinity-org avatar Feb 28 '24 19:02 daniel-wong-dfinity-org

ping @khs1994 , I see you merged some PRs recently.

calm-mlin avatar Mar 07 '24 21:03 calm-mlin

Probably even 300 would be enough. Often it takes just a bit more than 180 seconds:

In my case, it takes 421s, so around 600 would be better.

+ '[' 421 -gt 600 ']'
  + /Applications/Docker.app/Contents/Resources/bin/docker system info
  + echo '::notice::-- Docker is ready.Wait time is 421 s'
  + uname -a

anitacaron avatar Mar 08 '24 10:03 anitacaron

I've switched to https://github.com/douglascamata/setup-docker-macos-action because of this issue. Works good for me

limpbrains avatar Mar 08 '24 10:03 limpbrains