docker-mailserver

docker-mailserver copied to clipboard

[TODO]: Tests - `test_helper.bats` refactor mailqueue test cases

1

### Description This was identified during [recent review feedback](https://github.com/docker-mailserver/docker-mailserver/pull/3732#discussion_r1438959991), that the test cases could probably be refactored: - _"wait_for_empty_mail_queue_in_container fails when timeout reached"_ - _"wait_for_empty_mail_queue_in_container succeeds within timeout"_ Presently it's...

polarathene

### Description As [discussed here](https://github.com/docker-mailserver/docker-mailserver/pull/3767#discussion_r1456502283). `mailserver.env` and the ENV docs aren't entirely in sync, and it adds a maintenance burden (_both in maintaining it and noise it often contributes to...

polarathene

[TODO]: CI - Support builds that can opt-out of cache

1

### Description - We should add a new input for the [manual dispatch of the image build workflow](https://github.com/docker-mailserver/docker-mailserver/blob/0889b0ff063a37b482113a684d934e4bd728a33c/.github/workflows/generic_build.yml) that allows skipping the `actions/cache` step. - Additionally, the scheduled workflow should...

polarathene

[WIP] [FR] Implement initial support for shared mailboxes

13

# Description This PR aims to align @matejak's PR with the current master and thus implement the shared-mailboxes feature in docker-mailserver (for the old PR see https://github.com/docker-mailserver/docker-mailserver/pull/1643). This PR is...

GoliathLabs

Why do we need externalTrafficPolicy local when using Proxy Protocol with Kubernetes?

6

### Subject Other ### Description In the documentation, I see the following text: ``` [Configure your Ingress](https://docker-mailserver.github.io/docker-mailserver/latest/config/advanced/kubernetes/#configure-your-ingress) With an [NGINX ingress controller](https://kubernetes.github.io/ingress-nginx), set externalTrafficPolicy: Local for its service, and add...

MohammedNoureldin

refactor: Helper function `_replace_by_env_in_file()`

2

# Description Some refactoring improvements and fixes to the escaping support: - `_replace_by_env_in_file()`: - Minor change to add support for usage with `saslauthd.conf` which differs with `:` for it's key/value...

polarathene

breaking(feat): Config Templates for LDAP support

19

# Description Implements the [proposed change](https://github.com/docker-mailserver/docker-mailserver/issues/3517#issuecomment-1702053878) "LDAP config override support (config files + ENV)". This is a rather large diff to review, but the feature is basically two new helper...

polarathene

### Subject Something else that requires developers attention ### Description This is a tracking issue related to information shared in [this comment](https://github.com/docker-mailserver/docker-mailserver/pull/3403#issuecomment-1694563615). --- ## Changes Amavis: - Consider configuring to...

polarathene

### Description As detailed in [this review comment](https://github.com/docker-mailserver/docker-mailserver/pull/3767#discussion_r1451811263), enabling POP3 will fail to retrieve any mail stored in junk (_even if incorrectly flagged as spam_). For those not using Rspamd...

polarathene

### Description This task is available for anyone that wants to tackle it. --- https://github.com/docker-mailserver/docker-mailserver/blob/0889b0ff063a37b482113a684d934e4bd728a33c/target/scripts/startup/setup.d/security/misc.sh#L228 While we don't support container restarts for config changes handled by the startup scripts, requiring...

polarathene