wordpress icon indicating copy to clipboard operation
wordpress copied to clipboard

Add PHP 8.4 support

Open twiesing opened this issue 1 year ago • 7 comments

Previously:

  • https://github.com/docker-library/wordpress/pull/666
  • https://github.com/docker-library/wordpress/pull/783
  • https://github.com/docker-library/wordpress/pull/861

twiesing avatar Nov 23 '24 10:11 twiesing

Would be super cool if we already have a PHP 8.4 image with WordPress to test the compatibility of plugins & themes.

Maybe @LaurentGoderre or @tianon can take a look at the PR?

twiesing avatar Nov 23 '24 10:11 twiesing

This is a great idea! Unfortunately, it looks like we get hung up on https://github.com/Imagick/imagick/issues/689 (and thus need https://github.com/Imagick/imagick/pull/690). :disappointed:

tianon avatar Nov 25 '24 23:11 tianon

pecl imagick is basically unmaintained.

@thueske This adds necessary patches to this PR to make the build work with php 8.4: https://github.com/thueske/wordpress/pull/1

sebcode avatar Nov 27 '24 22:11 sebcode

Has there been any work in WordPress upstream to evaluate this dependency (and alternatives)?

tianon avatar Nov 27 '24 23:11 tianon

@tianon I’m not aware of any alternatives being actively considered. Imagemagick is the best option for processing images with PHP. GD is a works too but produces lower-quality images. Main issue is the lack of proper maintainer support of the pecl wrapper library. I think for now, the best approach is patching the library, which is also what Ondřej (maintainer of the widely-used PHP packages for Debian and Ubuntu) does.

sebcode avatar Nov 28 '24 15:11 sebcode

Any updates based on this https://github.com/docker-library/wordpress/pull/932#issuecomment-2504900708? Would be great to have PHP 8.4 :)

twiesing avatar Dec 07 '24 07:12 twiesing

WordPress 6.7 adds PHP 8.4 beta support. The latest commit from imagick is Mar 18, 2023. I think the patch here from @sebcode is the best solution.

twiesing avatar Dec 11 '24 05:12 twiesing

Some update on the ImageMagick side:

https://github.com/Imagick/imagick/pull/690#issuecomment-2676082818

swissspidy avatar Feb 25 '25 09:02 swissspidy

I've just force pushed this with a rebase+squash and an update to use the freshly-released https://pecl.php.net/package/imagick/3.8.0RC2 for PHP 8.4 (leaving other versions as-is on 3.7.0+patch given it's a pre-release).

tianon avatar Mar 13 '25 21:03 tianon

Thank you! There aren't any multi-arch builds yet, is this a normal behavior?

twiesing avatar Mar 14 '25 05:03 twiesing

Thank you! There aren't any multi-arch builds yet, is this a normal behavior?

Yeah, different architectures build at different speeds, and they are added to the image index as they are finished. We also merged a php security update at the same time, so the queues were (and are) still full for some architectures (https://doi-janky.infosiftr.net/). It looks like quite a few have finished building the wordpress:*php8.4* images and they are available on Docker Hub.

yosifkit avatar Mar 14 '25 16:03 yosifkit