redis icon indicating copy to clipboard operation
redis copied to clipboard

Adding support for docker secrets

Open kitingChris opened this issue 1 year ago • 4 comments

To pass the value for --requirepass password in a secure way docker secrets can be used with this pr.

If a secrets file is available and not empty it the password is passed to the server option --requirepass

kitingChris avatar Apr 10 '23 01:04 kitingChris

Duplicate of https://github.com/docker-library/redis/issues/268

(see especially https://github.com/docker-library/redis/issues/268#issuecomment-776877231)

tianon avatar Apr 11 '23 21:04 tianon

This is not an issue but an pull request. It solves #268. While the ACL approach may be the better solution my goal only was to get it running with requirepass and passing the password as secret.

kitingChris avatar Apr 11 '23 23:04 kitingChris

When we said we didn't plan to implement it, we also meant we didn't plan to accept/maintain the code (sorry for the lack of explicit clarity there).

tianon avatar Apr 11 '23 23:04 tianon

And why is it not planned to implement it? It is not a very complex code.

EDIT: the requirepass functionality is in many scenarios still the most used one. In my case with nextcloud. Using an ACL would mean to manage the password in 2 separate ways instead of one.

kitingChris avatar Apr 11 '23 23:04 kitingChris