golang icon indicating copy to clipboard operation
golang copied to clipboard

Run upstream tests on images in CI here

Open tianon opened this issue 11 months ago • 3 comments

This runs upstream's dist test which is roughly go test std cmd.

Fixes https://github.com/docker-library/golang/issues/552

tianon avatar Feb 14 '25 22:02 tianon

Ouch, I knew they'd be rough, but 10-11 minutes is even heavier than I was picturing.

tianon avatar Feb 14 '25 22:02 tianon

On the upside, total "wall clock" for https://github.com/docker-library/golang/actions/runs/13339366508 (current master) is ~23m 56s and https://github.com/docker-library/golang/actions/runs/13338265228 (this PR) is ~30m 36s.

tianon avatar Feb 15 '25 00:02 tianon

I agree to adding tests to ensure that the go binaries work as expected in the container environment but the comparison to the most recent run on master is not quite accurate since it took so long because of the Windows 2025 failures (cancelled last week in 22m 59s). Looking at runs before that like https://github.com/docker-library/golang/actions/runs/13297417083 and the complete wall clock is ~14 minutes but greatly slowed by pulling windows images 😢. It's complicated. 🫤

I think the biggest extra slowdown is the serial testing of 1.24 and then tip, though I am unsure if running multiple dist test at the same time will be significantly faster since it is CPU heavy. But, running the DOI tests in parallel is not something we can change in this repo.

yosifkit avatar Feb 24 '25 22:02 yosifkit