golang icon indicating copy to clipboard operation
golang copied to clipboard

Update Git for Windows to 2.48.1

Open tianon opened this issue 11 months ago • 2 comments

It's been a while since we updated this, we probably should (and maybe more often; perhaps automated). :see_no_evil:

tianon avatar Feb 14 '25 00:02 tianon

Of course, quite notably, I'm not comfortable merging this right now thanks to https://github.com/docker-library/official-images/pull/18435#issuecomment-2654277193:

The problem is that the windows-2025 runner is too old to run the mcr.microsoft.com/windows/servercore:ltsc2025 image released this week (https://github.com/actions/runner-images/issues/11582).

:upside_down_face: :sob:

tianon avatar Feb 14 '25 00:02 tianon

perhaps automated

If we use our current automation, this will be updated without being tested (because testing Windows is a blind-spot in our current automation until it pushes the commit and GitHub does a test).

tianon avatar Feb 14 '25 01:02 tianon

Close/open to retrigger GitHub Actions now that https://github.com/actions/runner-images/issues/11582 is resolved

yosifkit avatar Mar 03 '25 23:03 yosifkit

perhaps automated

If we use our current automation, this will be updated without being tested (because testing Windows is a blind-spot in our current automation until it pushes the commit and GitHub does a test).

Yeah, until we include Windows tests in our automated update.sh job we should not do it there. Maybe automated PRs to have GHA run the test builds. Perhaps that would just be the git updates and not replace the auto-committed go version bumps of the update.sh job.

yosifkit avatar Mar 12 '25 23:03 yosifkit