docs icon indicating copy to clipboard operation
docs copied to clipboard

Docs for Liquibase Official Image

Open r2-lf opened this issue 4 years ago • 2 comments

Hi! This is doc PR for https://github.com/docker-library/official-images/pull/8409.

r2-lf avatar Sep 28 '20 15:09 r2-lf

Hi, @tianon ! I am pretty sure there is no newline at the end of content.md. Did I mess it up somehow and I'm not seeing it? Thanks!

r2-lf avatar Sep 28 '20 15:09 r2-lf

Just checked golang/content.md and there are newlines at the end of the file. so, i'm not sure what the issue is here. thanks!

r2-lf avatar Sep 28 '20 15:09 r2-lf

It's strange that GitHub doesn't show it in the diff, but it looks like a few more files are missing the newline-at-EOF :eyes: (specifically maintainer, license, and content)

tianon avatar Apr 09 '24 17:04 tianon

@tianon I added the lines and you can see them while editing the file: image

jandroav avatar Apr 10 '24 06:04 jandroav

@tianon I can see the newlines when editing the file, in my IDE, and in codespaces but not in the github UI for some reason.

jnewton03 avatar Apr 11 '24 16:04 jnewton03

i added a space on the newlines and its showing now in the diff

jnewton03 avatar Apr 11 '24 16:04 jnewton03

It was successfully green and correct at 80b59f075a310574834585d7e6b896d5db2b2ad9 :sob:

I'd suggest cloning locally, and doing git reset --hard 80b59f075a310574834585d7e6b896d5db2b2ad9 and a force push to get back to that (good) commit.

tianon avatar Apr 11 '24 23:04 tianon

Done @tianon

jandroav avatar Apr 12 '24 04:04 jandroav