doccano-client icon indicating copy to clipboard operation
doccano-client copied to clipboard

Published 20 hours ago • verified publisher icon doccano

Publish New Version to PyPi with the Beta Client

Open ljades opened this issue 3 years ago • 10 comments

Feature description

Thanks for the prompt reviews on my code introducing the beta client code! Now, coinciding with https://github.com/doccano/doccano-client/issues/60 's steps forward, can we publish a new version to pypi with this code? Once we do, we can introduce new changes to get the beta client 1.6+ compatible.

ljades avatar Jun 21 '22 19:06 ljades

@Hironsan are you the only one with publishing power? Also, is there a way I can be made a code contributor/reviewer for this package since I built out the new beta client? There's an outstanding PR with some fixes here that I'd love to be able to help review.

ljades avatar Jun 28 '22 21:06 ljades

It's actually probably best that this version of the package not get published until that #71 is merged.

ljades avatar Jun 28 '22 21:06 ljades

Hey @afparsons and @Hironsan , sorry to bump and mention this again, but can we get an update on this? I'm actually going to be leaving my current company in the next three weeks, and I'd love to get an answer for if we can get contribution power or granting it to my coworker, @houssam7737. It'd allow us to switch to and develop actively on this package from our own internal package. It'd also give us more person-power to review new PRs on this repository.

Thank you in advance! And if that's too much to ask let me know as well.

ljades avatar Jul 20 '22 14:07 ljades

Hi @ljades Sorry for the late reply.

Should I add you (and @houssam7737 ) to doccano-client team and grant permission to commit?

Hironsan avatar Jul 21 '22 00:07 Hironsan

Hi @Hironsan , yes please that would be greatly appreciated. Thanks!

houssam7737 avatar Jul 21 '22 14:07 houssam7737

Yes, thank you in advance!

ljades avatar Jul 21 '22 16:07 ljades

@houssam7737 @ljades I sent you invitations. Please accept it.

Hironsan avatar Jul 22 '22 04:07 Hironsan

@ljades Do you have an estimate on when the new doccano-client version will be published to PyPI?

armandgurgu23 avatar Aug 07 '22 23:08 armandgurgu23

Hi @armandgurgu23 , unsure. I do not personally have publish credentials or even guidelines for doing that. That would still be a question for @Hironsan . That being said, I can at least suggest that until a new PyPi version is published, you can do an install directly from github and a git commit hash. Hope that helps!

ljades avatar Aug 08 '22 04:08 ljades

Can you have permission to create a tag and release the code? If you have it, the package will be automatically published to PyPI by the following workflow:

Oh, but before releasing it, we need to fix the package version.

https://github.com/doccano/doccano-client/blob/fe125f409138d319fb1c74a0d3c41225c539e7f8/setup.py#L25

Hironsan avatar Aug 08 '22 09:08 Hironsan