docat icon indicating copy to clipboard operation
docat copied to clipboard

Added multi platform docker image

Open EliasB-NU opened this issue 8 months ago • 9 comments

Like I mentioned in #917 , I would love to have the docker image for arm64 as well. I made a few changes, since I don't understand any of this matrix variables I just copy pasted my config and adjusted it. You would need to add the checks you have and the matrix vars you use.

EliasB-NU avatar Apr 03 '25 18:04 EliasB-NU

doesn't work :shrug:

ERROR: invalid tag "ghcr.io/docat-org/docat:$(git describe --tags)": invalid reference format

fliiiix avatar Apr 07 '25 10:04 fliiiix

I will look into it later today

EliasB-NU avatar Apr 08 '25 07:04 EliasB-NU

I am a little bit confused, the tags in the docker image correspond to the tags of the releases, but the actions only run on pushes and pull requests. Where did the previous actions get the tags from?

EliasB-NU avatar Apr 08 '25 16:04 EliasB-NU

I am a little bit confused, the tags in the docker image correspond to the tags of the releases, but the actions only run on pushes and pull requests. Where did the previous actions get the tags from?

I guess previously

      - name: Build Image
        run: |
          docker build . --build-arg DOCAT_VERSION=$(git describe --tags --always) --tag ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:${{ github.sha }}
          docker tag ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:${{ github.sha }} ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:unstable

      - name: tag latest and version on release
        run: |
          docker tag ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:${{ github.sha }} ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:$(git describe --tags)
          docker tag ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:${{ github.sha }} ${{ matrix.registry.name }}/${{ matrix.registry.org }}/docat:latest
        if: startsWith(github.event.ref, 'refs/tags')

the part using $(git describe --tags) only was executed for startsWith(github.event.ref, 'refs/tags') tag builds Basically i guess always build and tag 'unstable' and only on tag builds also tag 'latest' and the actual tag

fliiiix avatar Apr 09 '25 12:04 fliiiix

This might work but it seems this environment is not able to install yarn packages???

#22 211.6 error Error: https://registry.yarnpkg.com/@mui/icons-material/-/icons-material-6.1.3.tgz: ESOCKETTIMEDOUT

fliiiix avatar Apr 09 '25 14:04 fliiiix

I see, it should work, because I could compile it on my arm server, maybe its some weird issue with github workers.

EliasB-NU avatar Apr 09 '25 15:04 EliasB-NU

Maybe just updating the dependencies will fix it lets see :shrug: https://github.com/docat-org/docat/pull/919

fliiiix avatar Apr 10 '25 05:04 fliiiix

ok idk seems not to work for our docker image / build process :shrug:

fliiiix avatar Apr 10 '25 11:04 fliiiix

I don't understand it, maybe someone else in the future will have the same problem and fix it xD

EliasB-NU avatar Apr 10 '25 20:04 EliasB-NU