docat
docat copied to clipboard
docat-org
Fix versions selection
On UI: Modified buttons on the docs page to look like the buttons on home page. Also prevents overlay of the select field with the versions button.
On version switching behavior: Keeping the doc path when switching between versions. I think you tried to do that but was definitely not working on my system. I had to change the repository functions. Added some tests ofc.
@galaplexus does this depend on https://github.com/docat-org/docat/pull/167 ? if not please rebase and cleanup your commits
@galaplexus thanks for rebasing :tada:
@randombenj did you had a chance to review these changes? As this will be the next MR to tackle after https://github.com/docat-org/docat/pull/167
@galaplexus Thanks again for this MR!
-
Please don't redesign the home and version selection button as this was intentionally designed this way after some discussion with @BrunnerLivio and working on this issue: https://github.com/docat-org/docat/issues/122 Also, right now the selected verison is not shown correctly.
-
I tested the path persistence and it doesn't seem to work for me, it always redirects to the home of the selected version. I have to admit that the current implementation is quite strange with some quirks and I wanted to rewrite it but never had the time until now ...
-
It's not really a redesign and my new solution is still compatible with your drawing. One may even argue I use less space on the underlying docs. For me the other solution was really hard to use: impossible to close the selection tab and almost impossible to hit the home button. I think it makes more sense to keep a similar look to the home page. You wrote: "right now the selected version is not shown correctly." WDYM?
-
Just fixed it. Somehow I had to force change the version manually on web/src/pages/Docs.vue line 31
I think the main point here is still the redesign but currently nobody has time to review it and make a decision to move forward with this
I think the main problem with this PR is that this looks weird ->
And I can not reproduce the issue this pr is fixing. Unless these 2 issues are not addressed im inclined to close this PR. What do you think @galaplexus & @randombenj ?
The MR fixes:
- The version selection overlays with the "select version" button and the home button.
- Clicking outside of the version selection doesn't close the window. The only way I found how to close the window is to reload.
- When you are on a page and you change version, you are redirected to the home page. My MR keeps the path of the current page.
To your concern about the "weird look". I have not been shocked by it ^^ but maybe can you explain what you find weird?
The version selection overlays with the "select version" button and the home button.
Fair that is an issue but you can click on the same versions to close the version selector again. (which is not very obvious)
When you are on a page and you change version, you are redirected to the home page. My MR keeps the path of the current page.
I see we should fix that.
What about keeping the old design but just offset the selection menu to the top of the menu?
Yes I have tried offsetting higher but unfortunately this was not possible. I Googled it for quite a while. You are using md-options which doesn't give us much options. Also I think the round buttons looks good and it's nice to have consistency between pages.