docToolchain icon indicating copy to clipboard operation
docToolchain copied to clipboard

Overwrite arch with x86_64 in case of i386

Open SimonCW opened this issue 3 years ago • 6 comments

All Submissions:

  • [ ] Did you update the changelog.adoc?
  • [ ] Does your PR affect the documentation?
  • [ ] If yes, did you update the documentation or create an issue for updating it?

The source of the documentation can be found in /src/docs/.

If you didn't find the time to update docs, please create an issue as reminder to do so.

Your first submission

  • [x] Welcome to the list of contributors! If you have any questions, feel free to ask them by creating a new issue
  • [x] Have you added your name to the list of 30_community.adoc?

As discussed here: https://github.com/docToolchain/docToolchain/issues/1082

SimonCW avatar Mar 16 '23 10:03 SimonCW

Deploy Preview for dtc-docs-preview ready!

Name Link
Latest commit 372f53a974364b7b136bd9fdd5113aed6aca520f
Latest deploy log https://app.netlify.com/sites/dtc-docs-preview/deploys/641392adb2557d000863dd87
Deploy Preview https://deploy-preview-1084--dtc-docs-preview.netlify.app/10_about/30_community
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Mar 16 '23 10:03 netlify[bot]

on a windows machine, arch will return x86_64, so this mod will be fine

rdmueller avatar Mar 16 '23 22:03 rdmueller

@mh182 please merge if you also think this is ok

rdmueller avatar Mar 16 '23 22:03 rdmueller

To be honest, just looking at those 5 lines of codes, in a couple of weeks, no one is going to understand them. At least I would not.

man arch gives me arch - print machine hardware name (same as uname -m).

So if we don't provide some context with the code (and maybe a reference to ticket #1082) I would refactor the code and delete those lines in a couple of weeks.

@SimonCW So how about providing a bit of documentation and explain why we have this strange code in there?

mh182 avatar Mar 17 '23 07:03 mh182

TBH, I'm not sure whether it should be in there at all. It might be that it is just a weirdness of my config on my Mac that it outputs:

$ arch -x86_64 /bin/zsh
$ arch
i386
$ uname -m
arm64

I didn't have time to investigate on my machine or research whether this is expected behavior. Just wanted to share my solution. I can check with a few colleagues that have the same machine next week. And try to find out how reliable arch / uname is for determining architecture.

Screenshot_20230317-090235.png

😜

SimonCW avatar Mar 17 '23 07:03 SimonCW

So, regarding the answer of chatgpt, uname -m is the wrong thing to do and it should always reflect the hardware architecture not the one of the emulator?

rdmueller avatar Mar 27 '23 11:03 rdmueller