Dominic Evans
Dominic Evans
@klauspost that’s a good thought. I see the rfkafka producer has a conditional around whether to include uncompressed size based on the linked zstd version https://github.com/edenhill/librdkafka/blob/3b73ceb2049777331f3e544270bd8d0cdcd41de5/src/rdkafka_zstd.c#L149-L156
@hackery so @wyndhblb saw an improvement (I believe) after @klauspost releases v1.11.5 of compress containing https://github.com/klauspost/compress/pull/306 — which I believe we've been using since Sarama v1.28.0 Can you confirm which...
@Smriti-OSS i think we still want to de-dupe at the consumer level as well, like in your PR
@MasterKenway you don't show the snippet of code where you're putting a *ProducerMessage into the AsyncProducer.Input() channel — you're definitely creating a new &ProducerMessage{...} for each message yes? Not re-using...
We should ensure we are synced up with the similar record size estimation code from the Java client [org/apache/kafka/common/record/AbstractRecords.java#L89-L157](https://github.com/apache/kafka/blob/da65af02e5856e3429259e26eb49986122e34747/clients/src/main/java/org/apache/kafka/common/record/AbstractRecords.java#L89-L157)
@HobbyBear thanks for putting together these changes. They look reasonable to me, but I have a couple of questions: 1. Please could you add some unittest coverage for the new...
The Go team decided long ago not to support DSA in crypto/tls under the wontfix of https://github.com/golang/go/issues/6868 There’s just some legacy support for it in the ssh package. I’m afraid...
@mbarbon the bit I'm not clear on here is whether the actual throughput of Sarama's producer writing messages to kafka has degraded or whether the internal goroutine mechanism for returning...
So the `quick` cmd already has cmdline options to let you specify a custom iPXE binary for BIOS, 32-bit UEFI and 64-bit UEFI And the remote clients specify in their...
I understand there isn't much information to go on here, but I thought I should raise an issue to have something recorded and I'm happy to capture whatever additional debug...