Dominic Evans

Ah, I was only doing `-d` without the basic option

PR https://github.com/IBM/sarama/pull/2563 is also relevant here

@iamnaman863 Sarama itself won't close any idle connections, but it sounds like you have an intermediate proxy or loadbalancer between your client(s) and the kafka brokers which is terminating tcp...

Closing as dupe of https://github.com/Shopify/sarama/issues/2058 believed to be fixed (via https://github.com/Shopify/sarama/pull/2214) in v1.33.0 and newer

Yep, so to summarise. [KIP-341](https://cwiki.apache.org/confluence/display/KAFKA/KIP-341%3A+Update+Sticky+Assignor%27s+User+Data+Protocol) Sticky Assignor was implemented under #1416 and is available since v1.24.0 [KIP-345](https://cwiki.apache.org/confluence/display/KAFKA/KIP-345%3A+Introduce+static+membership+protocol+to+reduce+consumer+rebalances) Static Membership was implemented under #2230 and is available since v1.34.0 [KIP-429](https://cwiki.apache.org/confluence/display/KAFKA/KIP-429%3A+Kafka+Consumer+Incremental+Rebalance+Protocol) Incremental/Cooperative...

Hmm. I’m not aware of any previous issues with Sarama not committing offsets. I can only assume that there was some issue with your MSK cluster in its infancy that...

Closing as fixed in Version 1.31.0

I knocked up this PR whilst reading the spec and debugging why using the all day helpers wasn't producing an all day event in my generated .ics files. After finding...

It seems #69 was raised and merged 2 days ago which resurrected #61 but doesn't fixup SetDuration 😔

Yes it will do, it's essentially the same fix for that area. I've rebased the changes on top of latest master so it includes the additional tests and the fix...