Dominic Evans

Results 244 comments of Dominic Evans

@panyuenlau this is actually an intentional behaviour in the server-side kraft code. See https://github.com/apache/kafka/blob/b2dea17041157ceee741041d23783ff993b88ef1/core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala#L290-L305 > When using KRaft, a cluster no longer has a single controller. Instead, nodes in the...

@panyuenlau sure, in the future we will of course add the DescribeQuorumRequest and Response protocol and we can expose this for the metadata topic in the admin.go code in the...

Good find. Yes let’s keep this issue open for now. For one, I’d like to add an FVT matrix that uses Kraft mode anyway and two, we should at least...

@pellared thanks for getting in touch and raising this issue. I hadn’t previously been aware of the sarama instrumentation wrappers in the opentelemetry contrib repo and will explore them. Do...

👋 I do still plan to look into this, but with vacation and work I just haven't had any free cycles yet. I should hopefully find some time soon

I'd started to explore the source code and was prototyping how it might be managed/maintained [here](https://github.com/dnwe/otelsarama). I need to become more familiar with running and using OpenTelemetry myself

@pellared yes that sounds like a good idea, thanks Robert

@songxinjianqwe yes exactly right, that bit of code is essentially Sarama's client-side implementation of [KIP-360: Improve reliability of idempotent/transactional producer](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89068820) / [KAFKA-8805: Bump producer epoch following recoverable errors](https://issues.apache.org/jira/browse/KAFKA-8805), and it...

@rhammonds1-kr it looks like you've set [MaxProcessingTime](https://github.com/Shopify/sarama/blob/6acb2767144a840d9cc423f2917617e3372da7be/config.go#L383-L400) to 100ms (which is also the default) in your consumer configuration and haven't changed [ChannelBufferSize](https://github.com/Shopify/sarama/blob/6acb2767144a840d9cc423f2917617e3372da7be/config.go#L470-L474) The "timed out feeding messages to the user"...

@insulaire are you configuring multiple consumers within the same go process using the same config? Looking at the code, `sarama.BalanceStrategySticky` is a global singleton and would end up incorrectly sharing...