Dominic Evans

@Derek-Hardy sure I can add the missing kafka version(s) to the matrix and the CI checks — though there's no specific requirement to match the broker version as we just...

So https://github.com/Shopify/sarama/pull/2406 adds 3.3.1 constants and includes it in the fvt testing matrix — this is still using it in zookeeper mode though, I'll probably look at making an fv...

It's not obvious what "last 100 messages" would mean in the context of a topic containing multiple partitions However, if you're just talking about a single topic partition, then yes...

@AmiKotia this message is attached to the DebugLogger rather than the main Logger https://github.com/IBM/sarama/blob/86816212a7aca81d7d64c5603bb1aeb7f8248a7a/client.go#L1036 So as long as you configure DebugLogger separately (by default it sends its output to Logger...

@AmiKotia the sarama logger isn’t levelled, we have two separate loggers that just write to whatever you provide, so it must be your logger impl that’s setting info level

@ForeverSRC it is always tricky providing a logging framework in a Go module library that will work for everyone. The existing pair of loggers provide a simple “Debug” and “Everything...

Not seen this happen since the associated PR was merged, closing

Failed just now in https://github.com/IBM/sarama/actions/runs/6012746470/job/16308708213?pr=2627 (see [latest.txt](https://github.com/IBM/sarama/files/12464998/latest.txt)) ``` --- FAIL: TestFuncTxnProduceNoBegin (1.20s) [DEBUG] 13:18:54.644896 Initializing new client [DEBUG] 13:18:54.645123 Successfully initialized new client [DEBUG] 13:18:54.645912 Connected to broker at 127.0.0.1:29094...

@ae-govau would this be sufficient? ```go if errors.Is(err, sarama.ConfigurationError) || errors.Is(err, sarama.ErrMessageSizeTooLarge) { // log non-retriable error and don’t retry send } ```

@ajeyprasad this sounds like a duplicate of https://github.com/IBM/sarama/issues/2322 which was fixed in [v1.38.0](https://github.com/IBM/sarama/releases/tag/v1.38.0) via https://github.com/IBM/sarama/pull/2387 I'd recommend updating to the github.com/IBM/sarama import path and pulling in the latest version of...