Dominic Evans

Results 244 comments of Dominic Evans

@napallday thanks for putting together this PR! RE: 3. mentioned by @prestona it looks like a bug in our decoding of the MemberMetadata in the JoinGroups response where we return...

That seemed to work well for me. I ran sarama, rdkafka and (Java) kafka-console-consumer in the same cooperative balance group and ran some chaos testing restarting each of them randomly...

@napallday no worries, so I set KAFKA_VERSION=3.3.2 and started up docker-compose as used in the FV with the toxiproxy routes configured and created a six partition topic called `cooperative-topic`. I...

Interesting. It took me a few attempts, but yes I also managed to trigger that IllegalStateException with a Java 2.8.1 consumer: ``` [2023-08-23 21:03:16,182] ERROR [Consumer clientId=consumer-sarama-coop-1, groupId=sarama-coop] With the...

@napallday OK I looked over [apache/kafka](/apache/kafka) and I see that they skipped this validation code in the kafka-client under [KAFKA-13406](https://issues.apache.org/jira/browse/KAFKA-13406) and PR [#11439](https://github.com/apache/kafka/pull/11439) due to issues with the verification and...

@napallday were you planning to do the follow up work around metrics, pause/resume and additional FV tests under this PR? I suppose the alternative would be to merge this as-is,...

@wwwjfy 👋🏻 thanks for getting in touch The issue with merging to main at the moment is that the PR branch introduces new interfaces of ConsumeV2 and ConsumerGroupHandlerV2, which we'd...

Yes I think the ideal scenario would be if we can rework this PR to keep the Sarama consumer interface consistent, but expose an opt-in similarly to the Java client...

Fixed in [v1.38.0](https://github.com/IBM/sarama/releases/tag/v1.38.0)