[Enhancement]: Aperture > Add separator to header when content scrolled
Is there an existing issue for this?
- [x] I have searched the existing issues
Description of problem
Currently when scrolled you see this:
Which "hides the header in a way.
Description of solution
IMO adding a bit of a separation would be good:
Animated gif with and then without border:
Used as test:
border-bottom: solid 1px #25678a;
Description of alternatives considered
No response
Anything else?
No response
Do you plan to contribute code for this enhancement?
- [x] Yes
Would you be interested in sponsoring this enhancement?
- [ ] Yes
Code of Conduct
- [x] I agree to follow this project's Code of Conduct
@bdukes can you assign this to me please?
done
Just a note here @Timo-Breumelhof that it should use the css-variables (or a variation of) and not a hardcoded color.
Just a note here @Timo-Breumelhof that it should use the css-variables (or a variation of) and not a hardcoded color.
Yes, this example was just directly added in Firefox to test
Can we use a shadow border instead? I am not a huge fan of the solid 1px border. Perhaps it could be similar to the shadow border that was added to the PersonaBar?
Yeah I agree, a subtle shadow would be nicer
Can we use a shadow border instead? I am not a huge fan of the solid 1px border. Perhaps it could be similar to the shadow border that was added to the PersonaBar?
Because a border would interfere with the general styling, I made it very subtle in my example. With a light BG next to it you don't see it. You only see it when overlapping the Blue BG. A shadow would be always visible, and the Theme does not use any shadows elsewhere AFAIK, which is why I felt the (mostly invisible) border would be better?
Sorry to dissent, but I LIKE the way it is now. Its a very effective demonstration of a one-pager and using links with anchors and a bonus of a nice easing transition/animation when clicking the links to jump to the right section of the page.
Sorry to dissent, but I LIKE the way it is now. Its a very effective demonstration of a one-pager and using links with anchors and a bonus of a nice easing transition/animation when clicking the links to jump to the right section of the page.
Thanks @jeremy-farrance - those were precisely my thoughts when designing/coding it. I am not opposed to changing it but I feel a solid 1px border "cheapens" the design look and feel.
Sorry to dissent, but I LIKE the way it is now. Its a very effective demonstration of a one-pager and using links with anchors and a bonus of a nice easing transition/animation when clicking the links to jump to the right section of the page.
@jeremy-farrance I'm not sure I understand your reply related to the border I suggested (which you would only see when you scroll over a dark background). But it's not my design so I'll close the issue.
@Timo-Breumelhof I'm not sure why you closed the issue. It is a worthwhile discussion/debate. This is an open source solution and therefore should be open to everyone's opinions/feedback, and ultimately contributions.
BTW, @david-poindexter I noticed the current solution of using pages with a custom anchor url does not work on a child portal.
BTW, @david-poindexter I noticed the current solution of using pages with a custom anchor url does not work on a child portal.
@Timo-Breumelhof can you add that as a separate issue?
@Timo-Breumelhof I'm not sure why you closed the issue. It is a worthwhile discussion/debate. This is an open source solution and therefore should be open to everyone's opinions/feedback, and ultimately contributions.
Well I would add a separator but it's your design and you prefer to keep it this way it seems, which is a very good reason not to change it IMO.
BTW, @david-poindexter I noticed the current solution of using pages with a custom anchor url does not work on a child portal.
@Timo-Breumelhof can you add that as a separate issue?
sure
@Timo-Breumelhof I'm not sure why you closed the issue. It is a worthwhile discussion/debate. This is an open source solution and therefore should be open to everyone's opinions/feedback, and ultimately contributions.
Well I would add a separator but it's your design and you prefer to keep it this way it seems, which is a very good reason not to change it IMO.
@Timo-Breumelhof this is not "MY DESIGN". This design belongs to the DNN Community and EVERYONE's opinion should matter. I am not a turf protector or gate keeper for this design, but I did want to voice my opinion. I am sorry if that comes across wrong. 😢
No worries, it's not a big issue to me..
@david-poindexter #6761
No worries, it's not a big issue to me..
@Timo-Breumelhof when you close an issue just because someone has a different opinion or doesn't agree, it comes across as being mad. So please forgive me for reading between the lines and just assuming you were mad. (I hate text-only communications. 😩)
For what it's worth IMO a subtle shadow there looks nice to give it just a touch of depth/separation even if there are no other shadows in the theme.
I tried box-shadow: 0 4px 4px -2px rgba(var(--dnn-color-foreground-r), var(--dnn-color-foreground-g), var(--dnn-color-foreground-b), 0.3); and to my eye, it looks great over white or blue.
And it is subtle enough to not look weird over images/text either