[Enhancement]: Search theme object > Remove Legacy / WEB option

[Timo-Breumelhof]

Is there an existing issue for this?

• [x] I have searched the existing issues

Description of problem

As we are looking at creating an MVC pipeline version of the Search SKO, I had a good look at it. IMO this be a good moment to look at "legacy" options.

Specifically the "web" option which has not worked for a long time with the set Google query (as google obviously does not allow "scraping" any more). You can use a URL from another provider (through the resx file) but I don;t think any search provider still supports that?

  <data name="URL.Text" xml:space="preserve">
    <value>https://www.google.com/custom?q=[TEXT]&amp;sa=Search&amp;client=pub-9770992166002654&amp;forid=1&amp;ie=ISO-8859-1&amp;oe=ISO-8859-1&amp;cof=GALT%3A%23008000%3BGL%3A1%3BDIV%3A%23336699%3BVLC%3A663399%3BAH%3Acenter%3BBGC%3AFFFFFF%3BLBGC%3A336699%3BALC%3A0000FF%3BLC%3A0000FF%3BT%3A000000%3BGFNT%3A0000FF%3BGIMP%3A0000FF%3BFORID%3A1&amp;hl=en&amp;sitesearch=[DOMAIN]</value>
  </data>

Test / demo theme:

https://github.com/40fingers/Dnn-Core-Theme-Object-Demos/blob/main/24.00-Search.ascx

Related to #6607

Description of solution

I suggest we remove the Web / legacy option and only use the advanced option. This would also make supporting MVC easier.

I suggest:

• Render a warning if the legacy option is used.
• Mark as deprecated
• Remove in next Major release

Description of alternatives considered

No response

Anything else?

No response

Do you plan to contribute code for this enhancement?

• [x] Yes

Would you be interested in sponsoring this enhancement?

• [ ] Yes

Code of Conduct

• [x] I agree to follow this project's Code of Conduct

[valadas]

On one side I do think that tying into a specific provider is wrong, on the others side I never knew we could customize with resx. I don't think however I have seen any DNN site that would use 2 search sources, it is always one or the other in what I have seen. So deprecating that I think is a good idea, if people need an external search, it is not too hard to build their own skinObject for it...

[Timo-Breumelhof]

On one side I do think that tying into a specific provider is wrong, on the others side I never knew we could customize with resx. I don't think however I have seen any DNN site that would use 2 search sources, it is always one or the other in what I have seen. So deprecating that I think is a good idea, if people need an external search, it is not too hard to build their own skinObject for it...

agreed