Dnn.Platform icon indicating copy to clipboard operation
Dnn.Platform copied to clipboard

[Bug]: Wrong handling of terms/privacy custom pages

Open morganalori opened this issue 9 months ago • 0 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues

What happened?

/privacy and /terms urls do not redirect to the Site Settings specified pages when available. These urls go to the built in generated ones. There is no way currently to prevent default generated /privacy and /terms from displaying, except by creating a page with that exact page name.

I did find https://github.com/dnnsoftware/Dnn.Platform/issues/6373 which is related, but different.

Site Settings has entries for Terms and Privacy pages (introduced for GDPR with https://github.com/dnnsoftware/Dnn.Platform/pull/2369). Currently the Site Settings: PortalSettings.PrivacyTabId and PortalSettings.TermsTabId, are only used/honored by the DNN controls Terms.ascx/Privacy.ascx as part of a dnn theme/skin. However if someone goes to the /privacy or /terms urls, they get the DNN built in one from DNN Platform\Website\App_GlobalResources\GlobalResources.resx instead of the Terms/Privacy page specified by the site manager in the Site Settings.

Asked to confirm behavior was not correct in https://github.com/dnnsoftware/Dnn.Platform/discussions/6465
and got confirmation sending users to the custom page is only handled in the skinObjects and not the url redirect/handling

Steps to reproduce?

  1. Setup local Privacy and Terms pages (not named /privacy or /terms)
  2. Site Settings: Point Terms and Privacy pages to the new local privacy/term pages created above
  3. navigate to /privacy or /terms on the dnn site

Current Behavior

/terms and /privacy redirect to the DNN automatic terms/privacy pages with boiler plate text

Site Settings: PortalSettings.PrivacyTabId and PortalSettings.TermsTabId, are only used/honored by the DNN controls Terms.ascx/Privacy.ascx if used in a theme

Expected Behavior

/terms and /privacy urls should in order of action

  1. serve up actual site page if exists
  2. Redirect to Site Settings defined terms/privacy page
  3. Redirect to DNN automatic terms/privacy pages

Relevant log output

N/A

Anything else?

I did find https://github.com/dnnsoftware/Dnn.Platform/issues/6373 which is related, but different.

introduced for GDPR with https://github.com/dnnsoftware/Dnn.Platform/pull/2369

Affected Versions

9.13.8 (latest release)

What browsers are you seeing the problem on?

Firefox, Chrome, Microsoft Edge

Code of Conduct

  • [x] I agree to follow this project's Code of Conduct

morganalori avatar Mar 26 '25 17:03 morganalori