Dnn.Platform icon indicating copy to clipboard operation
Dnn.Platform copied to clipboard

Change "All Users" to "Everyone"

Open Timo-Breumelhof opened this issue 1 year ago • 2 comments

fixes #6091

Summary

This must be the simplest PR in our history? ;-) I edited SharedResources.resx to replace "All Users" with "Everyone".

But there's one issue remaining, the Persona Bar does not use this resource key, in there "All Users" is hard coded. So IMO we should only implement this one if #6119 is fixed too..

Timo-Breumelhof avatar Aug 29 '24 14:08 Timo-Breumelhof

The role name should be localized in all scenarios (see #6119 that @Timo-Breumelhof also opened). Changing the localized text should be a completely safe change. So, once #6119 is resolved, this should be a pretty clean and safe change.

bdukes avatar Aug 29 '24 16:08 bdukes

Good point, however I would still prefer we handle all of "All Users" localization everywhere in one PR. It is referenced in a couple of localization paragraphs and I'd prefer it is named the same everywhere to avoid making it even more confusing if it is "All Users" in some places and "Everyone" in other places.

valadas avatar Aug 29 '24 18:08 valadas

Closed as superseded by #6133

Timo-Breumelhof avatar Sep 12 '24 13:09 Timo-Breumelhof