Feature/5819 improvements fixes

[skamphuis]

This PR relats to #5819 and covers the fixes:

• Prevent exception for missing PortalSetting PageHeadText
• Fix UpdatePortalInfo for new language when en-US not present
• Fix mail Null Reference exception in SendMail found in upgraded portals
• When NodeManipulator adds items they have no tabid, do not filter on null.
• Scheduler Fix for error thrown when no servers active

[mtrutledge]

What did the frequency of the monitor get changed to? Was it more than 10 minutes? What were the initial reasons why the frequency of that got changed? Just want to make sure we have the whole picture. I don't want a side effect of this change to let the scheduler run when there are no active servers in the list but a schedule has been told to run on a specific server.

On Mon, Oct 16, 2023 at 12:09 AM Stefan Kamphuis @.***> wrote:

@.**** commented on this pull request.

In DNN Platform/Library/Services/Scheduling/Scheduler.cs https://github.com/dnnsoftware/Dnn.Platform/pull/5821#discussion_r1360156370 :

@@ -128,6 +128,12 @@ public static bool ValidateServersAreActiveForScheduledItem(ScheduleItem schedul // Get the enabled servers with recent activity. var enabledServers = ServerController.GetEnabledServersWithActivity();

•            if (!enabledServers.Any())
  

Sorry for the delay,I had to dive into that.

We experienced that after changing the frequency of the Montior Web Servers task. It looks like if that task isn't running (or not frequently enough?) it might occur that there are no enabled servers and the exception that I'm catching here, is thrown.

— Reply to this email directly, view it on GitHub https://github.com/dnnsoftware/Dnn.Platform/pull/5821#discussion_r1360156370, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQIT7RBNBHNBJG6RTIVQYTX7TFTHANCNFSM6AAAAAA5CY4COM . You are receiving this because you were mentioned.Message ID: @.***>

[skamphuis]

@mtrutledge sorry, missed your question again. I'll get back at this.

[mitchelsellers]

@skamphuis I am gong to close this for now, you can re-open if you would like to adjust/submit for merging