Dnn.Platform icon indicating copy to clipboard operation
Dnn.Platform copied to clipboard

HTML Lang Attribute

Open Andy9999 opened this issue 3 years ago • 3 comments

By default the tag is rendered having the lang attribute set to language and location for example "en-us" for US English.

We don't want to differentiate between en-us and en-en for example, or de-de and de-au so we cut the location off leaving the two letters of the language code in the rendered tag. We are not big enough of a site to have individual pages for each location and language is enough.

I could submit this as a change if there is any interest in this and would be glad not having to make a custom build anymore.

What are your thoughts? Should this somehow be enabled/disabled? What would be the best way? Maybe the HostSetting or PortalSetting table? Would that be a good place to add a new setting? For example LanguageCodeWithoutLocation Y/N with the default being 'N'.

Here is some more info about the lang attribute: https://www.w3schools.com/tags/att_lang.asp

Best regards & happy DNNing Andy9999

Andy9999 avatar Mar 15 '22 12:03 Andy9999

I'd think a portal setting, maybe something like ExcludeRegionFromLanguageAttribute

bdukes avatar Mar 15 '22 14:03 bdukes

That is a great name for the setting! Thank you.

Andy9999 avatar Mar 15 '22 20:03 Andy9999

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

stale[bot] avatar Jul 31 '22 03:07 stale[bot]

This issue has been closed automatically due to inactivity (as mentioned 14 days ago). Feel free to re-open the issue if you believe it is still relevant.

stale[bot] avatar Nov 02 '22 03:11 stale[bot]