Dnn.Platform icon indicating copy to clipboard operation
Dnn.Platform copied to clipboard

Google Tag Connector Track for Admin Issues

Open cklenk opened this issue 2 years ago • 7 comments

Description of bug

When you first set up a Google Tag Manager Connection and enter a GTM id and hit save without checking the track for administrators. GTM will still load for admins. But if you check track for admins, hit save. Reload and go back and uncheck track for admins it finally stops loading GTM for admins.

Steps to reproduce

  1. Go to Settings > Connectors > Google Tag Manager
  2. Ensure a tracking code is added
  3. Leave change track for admins to false (default)
  4. Press save
  5. Check dom and see GTM still loads

Current behavior

GTM is still loading for admins even though track for admins is false (not checked)

Expected behavior

Expect it to not load GTM if that is not checked.

Error information

No errors, just does not what one expects.

Additional context

Wondering if this is related to #2782?

Affected version

  • [ ] 10.00.00 alpha build
  • [ ] 09.10.02 release candidate
  • [X] 09.10.01 latest supported release

Affected browser

  • [X] Chrome
  • [X] Firefox
  • [X] Safari
  • [ ] Internet Explorer 11
  • [X] Microsoft Edge (Classic)
  • [X] Microsoft Edge Chromium

cklenk avatar Oct 07 '21 20:10 cklenk

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

stale[bot] avatar Jan 09 '22 01:01 stale[bot]

Still an issue.

Thanks -Cameron

cklenk avatar Jan 18 '22 17:01 cklenk

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

stale[bot] avatar Apr 18 '22 20:04 stale[bot]

This issue has been closed automatically due to inactivity (as mentioned 14 days ago). Feel free to re-open the issue if you believe it is still relevant.

stale[bot] avatar Jul 31 '22 03:07 stale[bot]

Can we re-open this one? It's still an issue.

Thanks -Cameron

cklenk avatar Sep 07 '22 14:09 cklenk

Just in case someone needs it: I've created a duplicate (didn't find this one in search), where I've described what I've found out in the xml file in settings which seems to be a root cause. So whoever's going to work on it check it out if you need it: https://github.com/dnnsoftware/Dnn.Platform/issues/5198

P.S. Hope it's going to be fixed sooner then closed automatically for inactivity. ) It's been a long time already...

Constantine-Ketskalo avatar Sep 08 '22 12:09 Constantine-Ketskalo

Reopened sir

valadas avatar Sep 08 '22 21:09 valadas