Dnn.Platform icon indicating copy to clipboard operation
Dnn.Platform copied to clipboard

Published 20 hours ago • verified publisher icon dnnsoftware

Removal of the WebSlice options

Open joshgk00 opened this issue 3 years ago • 5 comments

Fixes #3703

Summary

The changes proposed here are to remove the WebSlice options from the Module Settings UI as well as the underlying tables, since it's no longer supported.

How to Test

  • Do a clean install of DNN Platform and verify that the install completes without any errors.
  • Upgrade an existing instance of DNN Platform and verify that the upgrade process completes without any errors
  • Verify that the "Is a WebSlice" options have been removed from the Module Settings > Page Settings > Basic Settings section

Before this fix:

  • Is a WebSlice options existed in Module Settings image
  • Views, Tables, Stored Procedures and Constraints referenced the IsWebSlice column in the TabModules table
    • TabModules Table image
    • TabModules Contraints image
    • TabModules Indexes image
    • vw_TabModules image
    • SP: AddTabModule image
    • SP: UpdateTabModule image

After this fix:

  • No options exist for the WebSlice Options in the Module Settings UI image

  • The Tables, Views, SPs, Indexes, and Constraints have been updated/removed

joshgk00 avatar Jun 16 '21 18:06 joshgk00

Why do we have this one and #4710 @joshgk00 ? Should we close #4710 ?

valadas avatar Jun 17 '21 00:06 valadas

I created a draft PR before I got the response that the changes should be pointed at the develop branch. #4710 can be closed out.

joshgk00 avatar Jun 17 '21 01:06 joshgk00

Awesome, I closed the other one.

valadas avatar Jun 17 '21 02:06 valadas

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

stale[bot] avatar Sep 21 '21 19:09 stale[bot]

I've pinned this PR so it won't be marked as stale again

bdukes avatar Sep 21 '21 20:09 bdukes