"From name" email user registration wrong

[Tychodewaard]

Description of bug

If you have the site registration set to 'none', a user gets an email to confirm registration. I have a customer who detected that the 'email from' email was correct but the 'from name' was from a non admin user.

What I detected:

• the email of the 'from name' user is the same as the email in host settings (settings - server settings - host email)
• the 'from name' user has the lowest UserID with that specific email address
• actually, there is 1 user with the same email address: this is the host user

It looks like the email is sent from the Username that has the same Email and the lowest UserID

Current behavior

people who get registered get an email from 'Jack' while Jack is not the sender

Expected behavior

people get an email from [DisplaynameHost]

Affected version

[ ] 09.09.01

[sleupold]

There is no "Sender" - the admin registering the user should usually not be exposed in the email. EXPECTED BEHAVIOUR Instead, the site email address, i.e. the email address of the admin users, specified in website settings, should be used. If, for any reason, this email is not set (user be deleted etc.) the host email address should be used.

[Tychodewaard]

@sleupold Agreed. That would also solve my other concern: it should be a portal setting, not a host setting. Would it make sense to populate a dropdown from users with admin role?

[sleupold]

@Tychodewaard You may select the user from admins, when specifying the "responsible" admin in site settings. If necessary, you may use the email address of a group on the mail server. IMO this is sufficient, anything beyond might be too difficult to use for novice DNN site owners. My 2 cents.

[Tychodewaard]

@sleupold agreed.

[sleupold]

PS: it might be useful to improve help text for the admin user in site settings: when it is being used and its email address.

[stale[bot]]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[Timo-Breumelhof]

please...

[valadas]

Do we have any consensus of what needs to change within DNN on this issue here so I can triage this PR appropriately.

[skamphuis]

Well, yes. DNN should use the name of the selected primary administrator as the "From name" for emails that are being sent (in stead of the "from name" of the first user with the same email address as this primary administrator.

[valadas]

Thanks, triaged.