Accessibility Issue in Journal Module

[Timo-Breumelhof]

trafficstars

Description of problem

I have been doing some Accessibility test. I used the WAVE browser extension and it reports some errors.

Errors: A. The Author images are missing an Alt attribute B. The textareas does not have an associated label.

Description of solution

A. Add an alt attribute with the username to the image B. Add a hidden label for the textarea

Description of alternatives considered

none

Affected browser

All

[Timo-Breumelhof]

@valadas @bdukes @donker @david-poindexter can one of you please assign this to me? We will be fixing this for our client and do the PR

[bdukes]

yessir

[Timo-Breumelhof]

thankyousir @bdukes

[Timo-Breumelhof]

https://github.com/dnnsoftware/Dnn.Platform/blob/9f83285a15d23203cbaad72d62add864ab5b8c7f/DNN%20Platform/Modules/Journal/Components/JournalParser.cs#L389

https://github.com/dnnsoftware/Dnn.Platform/blob/9f83285a15d23203cbaad72d62add864ab5b8c7f/DNN%20Platform/Modules/Journal/Components/JournalParser.cs#L369

[stale[bot]]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[Timo-Breumelhof]

I did not have time for this yet.. :-)

[stale[bot]]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[valadas]

@Timo-Breumelhof any progress on this ?

[Timo-Breumelhof]

In the coming weeks I'll work on it.

[thabaum]

Looking at this link below as well as I am thinking about adding a link for images, or some form of a hover click action to add some spice of life to the community module. Similar to GitHub was my vision in some ways. There is a template ResX file SharedResources for the journal that shows all the templates used. This is the beginning of the <img but the file template depending on JournalType which by default is a status or comment in language files. You will see this maybe the place to edit as you please with some limits.

Right here is where I believe we can address the issue:

• Edit the Journal Language Files Editor areas like this DNN Platform source file and you will see the templates like journal_comment and journal_groupcreated and many more... lots of work here to do it all up right ;) I am adding logic in this area regarding a second version that needs to address when things are being made in social groups.. which doubles the templates so to speak if I try to write for all things possible. To start I will stick with just what is missing big time... and so my head is in this area now to help you get this resolved.
• Using this below along with other accessibility tutorials I plan on using for guidance. https://www.w3.org/WAI/tutorials/images/ I plan on going through all the tutorials with the module as I review and update the default templates HTML code. This will help both our goals out. However if they can get a new version in, I can work off with the latest update I applied along with your changes you feel are most needed. This can be accomplished sooner rather than later as I am hoping to go through all of it very thoroughly before presenting it as it will have multiple files with updates. I am trying to come up with about 2-3 ways to do the same thing and pick what I feel is most logical to start with for a solution.

In the end I will try to work this into a full PR with discussion, but don't let me stop you from taking what I have learned and creating something for a starting point as a PR as well if it helps. Then for sure your issue here is addressed as desired and possibly sooner...

If waits for me, which it can no worries here, once I submit a working PR everyone can see what may need addressed to finalize it for the community as best seen fit. Any feedback in general along the way will help me out here in regard to the link above displaying what I am showing for my guidance going forward on topic.

Have a fun safe traveling holiday season with family everyone, a Merry Christmas and a Happy DNN Deuce-Deuce on its way!