Dnn.Platform
Dnn.Platform copied to clipboard
dnnsoftware
Removal of the WebSlice option
Description of problem
Well, you know IE 8 technology and such, I think we could clean that up and remove it.
Description of solution
Kill it :)
Description of alternatives considered
Live in 1999
Additional context
Since we no longer run tests for the browsers (well the one) that had support for this, I think we should remove it because we are not going to really support that anyway.
We must not forget to remove the localization keys relating to this feature too.
Affected browser
- [ ] Chrome
- [ ] Firefox
- [ ] Safari
- [x] Internet Explorer
- [ ] Edge
We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'm working on this issue. @sleupold and @valadas can you point me to an example of how to include database changes? It looks like at the very least the vw_Modules would need to be updated to remove the WebSlice related columns, as well as the underlying table(s) the view is created from. As a new contributor, I'm not sure the best way to capture these changes.
@joshgk00 thanks so much for our interest in contributing! Database changes are typically handled in an upgrade script file for DNN or the module within DNN. I am on my phone at the moment and cannot easily point to examples, but I'll try to circle back a little later and provide some examples.
@david-poindexter I see there's a Upgrade.SqlDataProvider. I take it I would add the changes to that script? Since it looks like this issue is not slated until 10.0 release, I assume when this gets merged it'll be part of the upgrade script for the release it's merged into?
Actually, just found. @joshgk00 - you'll find the DNN scripts here for each version.
https://github.com/dnnsoftware/Dnn.Platform/tree/develop/DNN%20Platform/Website/Providers/DataProviders/SqlDataProvider
For this one, it is marked for removal I believe in 10.00.00. So you would need to add the necessary script to the appropriate file. If it doesn't exist already, you would need to create it.
@joshgk00 FOr this one, since the removal is in 10.0.0, it might be best to hold on this for a bit. As we will be unable to merge necessarily for quite a while.. (Just making you aware)
@mitchelsellers Thanks for the heads up. Maybe I'll just keep this branch in my fork for now and then take another look at the code and submit the PR a bit closer to when 10.0.0 is under development.
We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!
We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!
We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!