IllegalStack icon indicating copy to clipboard operation
IllegalStack copied to clipboard

Book Crasher Abusing IllegalStack

Open CoreyShupe opened this issue 4 years ago • 2 comments

Basically using a book to abuse the meta checks with illegal stack:

[19:26:57] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH  - xxx (MC: 1.16.1) ---
[19:26:57] [Paper Watchdog Thread/ERROR]: The server has not responded for 25 seconds! Creating thread dump
[19:26:57] [Paper Watchdog Thread/ERROR]: ------------------------------
[19:26:57] [Paper Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Paper!):
[19:26:57] [Paper Watchdog Thread/ERROR]: Handling packet for player xxx
[19:26:57] [Paper Watchdog Thread/ERROR]: Position: xxx
[19:26:57] [Paper Watchdog Thread/ERROR]: Total packets processed on the main thread for all players: 23592957
[19:26:57] [Paper Watchdog Thread/ERROR]: ------------------------------
[19:26:57] [Paper Watchdog Thread/ERROR]: Current Thread: Server thread
[19:26:57] [Paper Watchdog Thread/ERROR]: 	PID: 43 | Suspended: false | Native: false | State: RUNNABLE
[19:26:57] [Paper Watchdog Thread/ERROR]: 	Stack:
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Pattern$BmpCharPredicate.lambda$union$2(Pattern.java:5700)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Pattern$BmpCharPredicate$$Lambda$30/0x00000008000c6840.is(Unknown Source)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Pattern$BmpCharProperty.match(Pattern.java:3963)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Pattern$Curly.match0(Pattern.java:4405)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Pattern$Curly.match(Pattern.java:4379)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Pattern$GroupHead.match(Pattern.java:4804)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Pattern$Branch.match(Pattern.java:4747)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Pattern$GroupHead.match(Pattern.java:4804)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Pattern$Branch.match(Pattern.java:4749)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Pattern$Start.match(Pattern.java:3619)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Matcher.search(Matcher.java:1729)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.util.regex.Matcher.find(Matcher.java:746)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_16_R1.util.CraftChatMessage$StringMessage.<init>(CraftChatMessage.java:71)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_16_R1.util.CraftChatMessage.fromString(CraftChatMessage.java:192)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_16_R1.inventory.CraftMetaBook.addPage(CraftMetaBook.java:265)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_16_R1.inventory.CraftMetaBook.<init>(CraftMetaBook.java:94)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_16_R1.inventory.CraftMetaBook.<init>(CraftMetaBook.java:58)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_16_R1.inventory.CraftItemStack.getItemMeta(CraftItemStack.java:286)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.craftbukkit.v1_16_R1.inventory.CraftItemStack.getItemMeta(CraftItemStack.java:275)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		me.dniym.listeners.fListener.onInventoryPickup(fListener.java:2316)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor208.execute(Unknown Source)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.plugin.EventExecutor$$Lambda$3391/0x0000000800ca8c40.execute(Unknown Source)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:607)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.PlayerConnection.a(PlayerConnection.java:2607)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.PacketPlayInSetCreativeSlot.a(SourceFile:23)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.PacketPlayInSetCreativeSlot.a(SourceFile:9)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.PlayerConnectionUtils.lambda$ensureMainThread$1(PlayerConnectionUtils.java:43)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.PlayerConnectionUtils$$Lambda$6735/0x000000080233ac40.run(Unknown Source)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.TickTask.run(SourceFile:18)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.MinecraftServer.aZ(MinecraftServer.java:1193)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.MinecraftServer.executeNext(MinecraftServer.java:1186)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.IAsyncTaskHandler.executeAll(IAsyncTaskHandler.java:95)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.MinecraftServer.a(MinecraftServer.java:1317)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.MinecraftServer.v(MinecraftServer.java:1002)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.MinecraftServer.lambda$a$0(MinecraftServer.java:179)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_16_R1.MinecraftServer$$Lambda$2999/0x0000000800908c40.run(Unknown Source)
[19:26:57] [Paper Watchdog Thread/ERROR]: 		[email protected]/java.lang.Thread.run(Thread.java:834)
[19:26:57] [Paper Watchdog Thread/ERROR]: ------------------------------
[19:26:57] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH ---
[19:26:57] [Paper Watchdog Thread/ERROR]: ------------------------------

CoreyShupe avatar Sep 18 '20 23:09 CoreyShupe

Hmmmm i just checked the source code, and you're running a different version than the current version as the line numbers don't line up.

I suspect it may be the author field but can you try on the latest version of IllegalStack? https://www.spigotmc.org/resources/dupe-fixes-illegal-stack-remover.44411/

dniym avatar Sep 19 '20 00:09 dniym

Hmmmm i just checked the source code, and you're running a different version than the current version as the line numbers don't line up.

I suspect it may be the author field but can you try on the latest version of IllegalStack? https://www.spigotmc.org/resources/dupe-fixes-illegal-stack-remover.44411/

Just checked the source, it’s linking to the same method just a bit further down. The is.getItemMeta is triggering it. The issue is deeper I think with just an illegal item. I can’t reproduce since I don’t have a hacked client to trigger such a thing. It was a crashing book which utilized the instant getMeta from the item set slot method. I’m not sure if it’s in the scope of IllegalStack.

CoreyShupe avatar Sep 19 '20 02:09 CoreyShupe

IllegalStack version 2.8 is now out, if you are still experiencing this issue please open a new ticket.

dniym avatar Jun 14 '23 21:06 dniym