Fixing install_mac.sh

[Ghostboo-124]

Changing make server to make llama-server Adding brew install ccache for faster compilation times

Summary by CodeRabbit

• Installation Enhancements

  • Updated installation instructions in the README for improved clarity.
  • Introduced a step for users to switch to the macOS branch before installation.
  • Added explicit installation commands for espeak-ng and ccache.

• Performance Improvements

  • Improved user feedback during installation with echo statements.
  • Enhanced compilation times by integrating ccache in the installation process for macOS.

• Build Process

  • Renamed the compilation target from make server to make llama-server.
  • Updated file paths in the installation script to ensure correct references.

[coderabbitai[bot]]

Walkthrough

The recent updates enhance the installation process for the GLaDOS project on macOS. Key improvements include clearer installation instructions in the README.md, the addition of ccache to optimize compilation speed, and the renaming of the compilation target to llama-server. The repository URL has been updated to reflect a new source, and guidance for switching to the macOS branch has been clarified.

Changes

File/Path	Change Summary
install_mac.sh	Added installation for ccache and espeak-ng; renamed target to llama-server; updated paths in sed command.
submodules/whisper.cpp	Updated submodule commit from 58210d6... to d207c68...
README.md	Updated repository URL and clarified installation steps, including branch switching

Poem

In the land of code where whispers flow,
ccache is here to speed the show.
A llama server, proud and new,
Compiles faster, just for you.
Whispers updated, fresh as spring,
CodeRabbit cheers, let us sing! 🎉🐰

[!TIP]

Announcements

• The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
• We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
• Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits

Files that changed from the base of the PR and between e683ad72f6d87e00da9801871cf15c4c98f986af and a07ce9a5989e5fae584c21615aa49bd24f5423d7.

Files selected for processing (1)

• install_mac.sh (3 hunks)

Additional context used

Shellcheck

install_mac.sh

[warning] 19-19: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

---

[warning] 31-31: In POSIX sh, 'source' in place of '.' is undefined.

(SC3046)

Additional comments not posted (4)

install_mac.sh (4)

19-19: Add error handling for directory change.

As suggested in the previous review, it's crucial to handle potential failures when changing directories to ensure subsequent commands run in the intended directory.

- cd $SCRIPT_DIR/
+ cd $SCRIPT_DIR/ || exit

Tools

Shellcheck

[warning] 19-19: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

---

31-31: Replace source with . for better POSIX compatibility.

As suggested in the previous review, using . instead of source ensures compatibility across different shells that adhere strictly to POSIX standards.

- source venv/bin/activate  
+ . venv/bin/activate

Tools

Shellcheck

[warning] 31-31: In POSIX sh, 'source' in place of '.' is undefined.

(SC3046)

---

49-49: LGTM!

The change in the compilation command from make server to make llama-server is approved.

---

60-60: LGTM!

The update to the path for the ggml-common.h file in the sed command is approved. This change ensures that the script correctly references the required header file based on the new directory structure.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ghost]

I am merging from the macOS branch of this so it has the windows install and start and requirements_cuda files removed, if merging removes those files from your main branch, then maybe just take the install_mac file

[dnhkng]

Sorry about the big delay in reviewing this pull request. I gave priority to working on GLaDOS's LLM to make her more intelligent (made 1st spot on the Open LLM Leaderboard with her new 'brain'.

I will be leaving today for an overseas holiday, I can review this when I'm back next month.

[dnhkng]

Should be fixed now!