flutter_svg icon indicating copy to clipboard operation
flutter_svg copied to clipboard
verified publisher icon dnfield

Error handling enhancement

Open minhhung2556 opened this issue 1 year ago • 3 comments

Title

Error handling when loading and parsing SVG files.

Purpose

This PR is related to https://github.com/dnfield/vector_graphics/pull/258, which will fix some related issues: https://github.com/dnfield/vector_graphics/issues/219 https://github.com/dnfield/flutter_svg/issues/1100 https://github.com/dnfield/flutter_svg/issues/1085 https://github.com/dnfield/flutter_svg/issues/1080 https://github.com/dnfield/flutter_svg/issues/1044 https://github.com/dnfield/flutter_svg/issues/996 https://github.com/dnfield/flutter_svg/issues/1007

Changes Made

  • catch error cases and return results to SVGPicture.
  • expose errorWidgetBuilder.

Testing

  • Already tested by example and unit test in flutter_svg

Impact

This change should not affect other parts of the library.

minhhung2556 avatar Oct 04 '24 10:10 minhhung2556

Hi there, The Flutter team is now maintaining this package in the flutter/packages repository at this location. We'd appreciate it if you could direct this PR to that location instead. Thanks!

zanderso avatar Nov 01 '24 21:11 zanderso

Hi @zanderso Here is my PR to flutter/packages. Thanks for your response.

minhhung2556 avatar Nov 04 '24 15:11 minhhung2556

any plans to merge this soon?

erperejildo avatar Dec 08 '24 18:12 erperejildo