Dan Field
Dan Field
I think we should in general avoid new code that introduces `camelCase` method names, and just use `PascalCase` or `snake_case` as appropriate. This is a nit and easily cleaned up...
This might have some unintentional impact on UBOs but all tests are passing so I'm hoping @bdero can spot that if it's a problem.
> All tests are passing lol I spoke too soon. Will look into tests.
> These two make for a pretty good smoke test of uniform breaking: > > * `RendererTest.InactiveUniforms` should show up as solid green on Metal and GLES. > * `RendererTest.ArrayUniforms`...
I talked to @zanderso - we had a test that was exercising defining a 2d array in a shader, but the usage of it was a bit odd. I'm amending...
There's some kind of race going on here. If I run the tests locally with `cpulimit -l 1`they sometimes fail the way CI is showing, other times not. Moving to...
I looked through https://developer.apple.com/documentation/metal/performing_calculations_on_a_gpu?language=objc again and the only meaningful difference I could find was that I was setting a much larger (and two dimensional) grid and workgroup size. If I...
On a similar note, it would be nice to have it check for new line at EOF and only one new line at EOF.
We don't use dartfmt in Flutter - for various reasons. We do expect users to not have whitespace at the end of lines and to have a new line at...
It's in https://github.com/flutter/flutter/blob/master/dev/bots/analyze.dart#L192-L203 We shell out to grep for all files git says have changed. It doesn't detect new line at EOF.