powderday

powderday copied to clipboard

code needs to barf if we request a region that is outside the original ds.domain

2

dnarayanan

we currently go through `gadget_field_add` twice in grid_construction.py. the first time is to establish the field aliases, and the second is to actually perform the smoothing on the octree. this...

dnarayanan

error trapping in beginning

2

we should try to have something catch errors in the very beginning of a run to crash. a running list includes: [1] looking for `CLOUDYEXE` if the neb emission is...

dnarayanan

this is pretty minor, but in (e.g. `gadget2pd` there's some inefficiencies that look like this: ``` def _dustsmoothedmasses(field, data): if yt.__version__ == '4.0.dev0': return (data.ds.parameters['octree'][('PartType0','Dust_Masses')]) else: return (data.ds.arr(data[("deposit", "PartType0_sum_Dust_Masses")].value, 'code_mass'))...

dnarayanan

dnarayanan

this may require digging into the AMRGridView methods in hyperion itself

dnarayanan

dust models need to be included for enzo front end

1

right now the enzo front end on master only works for dtm

dnarayanan

just put in docs where we can find this, as well as in the parameters_model file

dnarayanan

it would be good to give the user the advanced option of scatter vs gather SPH smoothing onto the octree for yt4.x. an example is here: https://github.com/yt-project/yt/pull/2400

dnarayanan

right now the code block in `enzo_tributary`: ``` energy_density_absorbed=energy_density_absorbed_by_CMB( energy_density_absorbed = np.repeat(energy_density_absorbed.value,amr['density'].shape) d = SphericalDust(cfg.par.dustdir+cfg.par.dustfile) if cfg.par.SUBLIMATION == True: d.set_sublimation_temperature('fast',temperature=cfg.par.SUBLIMATION_TEMPERATURE) m.add_density_grid(amr['density'],d),specific_energy=energy_density_absorbed) m.set_specific_energy_type('additional') #m.add_density_grid(amr['density'], cfg.par.dustdir+cfg.par.dustfile) ``` doesn't work due to the...

dnarayanan