powderday icon indicating copy to clipboard operation
powderday copied to clipboard

no PAHs in the enzo_tributary

Open dnarayanan opened this issue 4 years ago • 3 comments

dnarayanan avatar Mar 16 '20 18:03 dnarayanan

I've implemented this locally by adding a "multiply by a scalar" function to hyperion's AMRGridView class and then largely copying the PAH implementations from the other tributaries. Would it be helpful for me to try posting to the hyperion github to request this change?

anchwr avatar Jan 14 '21 23:01 anchwr

ah interesting! so within pd I would very much welcome a pull request and thanks so much for having done this. (to be honest I can't remember why I didn't do it myself when setting up the Enzo front end...I suspect I saved it for later to deal with then just never did).

but, I'm not sure I understand what you did within hyperion? is this scalar multiplication to mimic the energy of the CMB?

dnarayanan avatar Jan 15 '21 18:01 dnarayanan

Sorry - that was a very ambiguous description! I haven't tried to implement any of the CMB stuff yet. I implemented the scalar multiplication in hyperion so that I could multiply the AMR dust grid by the different PAH dust grain fractions - similar to https://github.com/dnarayanan/powderday/blob/cf2ed8ca79483f21a69147782112d07328ed8fc8/powderday/arepo_tributary.py#L85 I couldn't figure out a clean way to do this for the Enzo tributary without making a change to hyperion's AMRGridView class, since the dust grid read in by yt is an instance of this and it couldn't be multiplied by a scalar. I thought this might be why PAHs hadn't been implemented for Enzo yet!

anchwr avatar Jan 19 '21 05:01 anchwr