Damian Nadales

Results 136 comments of Damian Nadales

@pjljvandelaar Could you check which other components will be involved in this change? I'm guessing SMT as well.

The function above simply collects all the `LetVarDecl`'s. In the example above `x` is not a let variable declaration, so it won't be part of the result.

I see, you're looking for `y`. As far as I remember the `LET` expression of the example is not a `ExpDecl` but a behavior expression declaration ...

I think I fixed it, but @ramon-janssen and @pjljvandelaar please review.

Yes indeed. The PR I made only solves the bug that Ramon submitted. Regarding this issue, wasn't this behavior the same with the old parser?

@pjljvandelaar @keremispirli I've updated the issue by adding some checkboxes with the tasks I understand need to be finished in order to complete this task. @pjljvandelaar Please take a look...

> @keremispirli about the convention: I think we should use for the fields/accessors -- | when the constructor is NOT public and -- ^ when it is! Why not just...

> For me '--|' is as long as '--^' ... so I don 't understand your remark.... You use `-- ^` to refer to the element that precede the comment,...

> See http://haskell-haddock.readthedocs.io/en/latest/markup.html ... Ok, you meant the top level declaration. Why not stick to `-- |`? Less cognitive load (than having to remember conventions about whether it is a...

I built and installed `argon` on Linux, and it seems to work. See for instance the `lpe` code: ![screenshot from 2018-02-13 11-08-39](https://user-images.githubusercontent.com/175315/36144433-4a7b1be4-10ae-11e8-8fe9-6a601989e32a.png) Sadly I think it does not work on...