android-process-button icon indicating copy to clipboard operation
android-process-button copied to clipboard

disable button color

Open jjhesk opened this issue 9 years ago • 8 comments

Is that possible to add disable button color when the button is triggered with setEnable(false); or starting status with enable == false?

jjhesk avatar Mar 09 '15 09:03 jjhesk

Any chance to get that?

AdamCopperfield avatar Oct 27 '15 10:10 AdamCopperfield

Hi @dmytrodanylyk ,

I'm interested in the implementation of this feature, and could do the PR, if you have no developments on this issue.

Thanks!

redwerk avatar Dec 24 '15 12:12 redwerk

@redwerk please do.

dmytrodanylyk avatar Dec 24 '15 12:12 dmytrodanylyk

Hi @dmytrodanylyk,

Just a few questions about implementation. Do we need to save\restore state of the button on enabled\disabled or just set the background color on setEnabled(false)? Will user be able to setProgress when the button is disabled?

Thanks!

redwerk avatar Dec 28 '15 09:12 redwerk

@redwerk I will check PR on weekends. Got a lot of work, sorry.

Do we need to save\restore state of the button on enabled\disabled or just set the background color on setEnabled(false)? Will user be able to setProgress when the button is disabled?

Hmm... you don't need to use setEnabled method and change button color. If you want to make button not clickable just override touch listener and return true / false when button is in progress.

dmytrodanylyk avatar Dec 29 '15 21:12 dmytrodanylyk

@dmytrodanylyk I'm sorry, but I think we do not understand each other. As described by @jjhesk, the color of the button should change when setEnabled (false) fire. And that's what I'm doing now. But there are two questions. Should we save\restore the state of the button (e.g. progress) at setEnabled (true) \ setEnabled (false)? And will the user be able to use setProgress () when the button is disabled in order to avoid problems with the UI? With these questions, I just want to clarify the best way for implementation of this feature.

Thanks!

redwerk avatar Jan 04 '16 10:01 redwerk

Should we save\restore the state of the button (e.g. progress) at setEnabled (true) \ setEnabled (false)?

Yes

And will the user be able to use setProgress () when the button is disabled in order to avoid problems with the UI?

Yes, we want to disable button just to make sure user will not click on it again, when it's in progress state.

dmytrodanylyk avatar Jan 04 '16 10:01 dmytrodanylyk

Hi,

Here is PR #50

Thanks!

redwerk avatar Jan 11 '16 11:01 redwerk