WMCore icon indicating copy to clipboard operation
WMCore copied to clipboard

Explicitly set LFNBase during creation - Chained requests

Open amaltaro opened this issue 8 years ago • 6 comments

Fixes #8151 Since (un)mergedLFNBase is not mandatory during assignment (the same as AcqEra/ProcStr/ProcVer), we need to make sure the workload configuration (steps, output modules, etc) are coherent with the value passed during request creation.

These 2 spec files were missing that call, so even though the request json contains one MergedLFNBase, the workload config contains the default /store/data

Given that the workflow team always set those 2 parameters, I'd rather not merge and push it to the current testbed because I'm not sure whether it can have - bad - side effects, especially on StepChain.

amaltaro avatar Sep 07 '17 18:09 amaltaro

Jenkins results:

  • Unit tests: failed
    • 2 new failures
  • Pylint check: failed
    • 24 warnings and errors that must be fixed
    • 2 warnings
    • 11 comments to review
  • Pycodestyle check: succeeded
    • 9 comments to review
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/jenkins/view/All/job/DMWM-WMCore-PR-test/5888/artifact/artifacts/PullRequestReport.html

cmsdmwmbot avatar Sep 07 '17 19:09 cmsdmwmbot

that will not make lfnbase required at request creation time, will it ?

vlimant avatar Sep 08 '17 10:09 vlimant

No, it won't. However, it should be taken into account if provided.

amaltaro avatar Sep 11 '17 08:09 amaltaro

test this please

amaltaro avatar Oct 25 '17 15:10 amaltaro

Jenkins results:

  • Unit tests: failed
    • 5 new failures
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Pylint check: failed
    • 24 warnings and errors that must be fixed
    • 2 warnings
    • 11 comments to review
  • Pycodestyle check: succeeded
    • 9 comments to review
  • Python3 compatibility checks: failed
    • fails python3 compatibility test

Details at https://cmssdt.cern.ch/jenkins/view/All/job/DMWM-WMCore-PR-test/6288/artifact/artifacts/PullRequestReport.html

cmsdmwmbot avatar Oct 25 '17 16:10 cmsdmwmbot

Can one of the admins verify this patch?

cmsdmwmbot avatar Sep 30 '24 21:09 cmsdmwmbot