WMCore icon indicating copy to clipboard operation
WMCore copied to clipboard

Check WMArchive doc size and cut off big docs

Open vkuznet opened this issue 10 months ago • 5 comments

Fixes #11960

Status

In development

Description

Provide check for newly created WMArchive document before sending them to WMArchive service. The size threshold can be configured and by default equal to 8MB (current threshold on CMSWEB nginx). To avoid flooding log with very large docs a short version of the WMArchive document (a slice) is provided and printed out to the logger together with full size of the document and used threshold.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

External dependencies / deployment changes

vkuznet avatar Apr 15 '24 16:04 vkuznet

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 1 tests no longer failing
  • Python3 Pylint check: failed
    • 4 warnings and errors that must be fixed
    • 1 warnings
    • 2 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 3 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15014/artifact/artifacts/PullRequestReport.html

cmsdmwmbot avatar Apr 15 '24 16:04 cmsdmwmbot

A better solution would be to find the worst offender field, truncate it and move on with document injection.

Alan, I doubt your suggestion for better solution stands. We still need to find what is causing large data size and for that we need somehow to identify rejected docs. Without actual details how you want to hunt for worst offenders (please keep in mind that we may have combination of fields contributing to large data size) I think there is no such solution, we still need to reject and dump these docs to get full sense of the actual issue.

vkuznet avatar Apr 17 '24 13:04 vkuznet

Jenkins results:

  • Python3 Unit tests: succeeded
    • 3 changes in unstable tests
  • Python3 Pylint check: failed
    • 4 warnings and errors that must be fixed
    • 1 warnings
    • 2 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 3 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15020/artifact/artifacts/PullRequestReport.html

cmsdmwmbot avatar Apr 17 '24 13:04 cmsdmwmbot

@amaltaro , @anpicci should we resume this activity? I requested review of this PR once again, please give me your feedback should I proceed with it or not.

vkuznet avatar May 06 '24 11:05 vkuznet

@vkuznet In my understanding, the situation is similar to three weeks ago, so probably it would be better to keep this issue on hold until we finalize the containerization problem, even though I see your concern

anpicci avatar May 06 '24 13:05 anpicci

@vkuznet given that these changes are in a very initial state and that the original issue (WMAgent flaw on getting last 50 lines of log) was resolved, how about we close this out?

When time comes, we can track such developments with a new ticket: https://github.com/dmwm/WMCore/issues/12043

amaltaro avatar Aug 20 '24 16:08 amaltaro

As briefly discussed in the issue, I am closing this PR. Eventually we will revisit all this WMArchive integration. Thanks Valentin!

amaltaro avatar Sep 10 '24 20:09 amaltaro