WMCore icon indicating copy to clipboard operation
WMCore copied to clipboard

Fanzago cmsathome

Open fanzago opened this issue 1 year ago • 4 comments

Fixes #10751

Status

ready

Description

Patch to allow cleanup jobs to succeed in CMS@Home

Is it backward compatible (if not, which system it affects?)

MAYBE

Related PRs

We added a function for the T3_CH_CMSAtHome site to the DeleteMgr.py file in order to delete correctly files using the grinformation reported in the fallback section of the site configuration file

External dependencies / deployment changes

Does it require deployment changes? No. Does it rely on third-party libraries? No.

fanzago avatar Mar 15 '23 15:03 fanzago

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
  • Python3 Pylint check: failed
    • 5 warnings and errors that must be fixed
    • 2 warnings
    • 35 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 21 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14106/artifact/artifacts/PullRequestReport.html

cmsdmwmbot avatar Mar 15 '23 16:03 cmsdmwmbot

@fanzago Federica, thank you for creating this pull request.

I think we need now need to have someone from the WMCore team to evaluate:

  1. what are the usual parameters for a Cleanup job (from the site-local-config)
  2. how those compare to the fallback setup for T3_CH_CMS_At_Home
  3. how this is used by DeleteMgr
  4. and whether we can implement any generic solution

It might take a little to get back to this, but in case we have a WMAgent upgrade before that happens, we can always apply this patch while a permanent solution is investigated.

amaltaro avatar Mar 15 '23 23:03 amaltaro

@fanzago Federica, there has been some changes to the SITECONF setup and it inject conflicts into this pull request. If this is still relevant, could you update/rebase this PR?

amaltaro avatar May 06 '24 13:05 amaltaro

Can one of the admins verify this patch?

cmsdmwmbot avatar Sep 30 '24 20:09 cmsdmwmbot