Elegit icon indicating copy to clipboard operation
Elegit copied to clipboard

Elegit hangs when remote repo is unavailable

Open dmusican opened this issue 7 years ago • 3 comments

I'm sitting in a place with public free wifi that is blocking some ports. Git push on https fails due to the port being blocked. Elegit eventually times out, but it took a very long time (a full minute, perhaps?). Git push at the command line hangs also for a long time, but you can always ctrl-c out of it. Elegit needs some kind of cancel if push is hung.

dmusican avatar Apr 04 '17 16:04 dmusican

Having trouble recreating this timing out. However, I did find that it might be caused by having multiple remotes, as the popup window to show the remotes is a threading mess and difficult to bring to the foreground. On a repo that has one remote, does it time out slowly when all internet is blocked (I found this to time out in ~1 second) or just when some ports are blocked? Either way, we should have a ctrl-c option.

erictwalker18 avatar May 05 '17 03:05 erictwalker18

Agreed. Getting this right is undoubtedly tied into the threading overhaul I'm working on.

dmusican avatar May 09 '17 10:05 dmusican

I'll wait to pull request until after the threading overhaul. I fixed the issue with multiple remotes in hang-fix, but haven't found a proper way to stop a push/kill the working thread mid execution unless it is looping through something.

erictwalker18 avatar May 09 '17 14:05 erictwalker18