iSponsorBlockTV icon indicating copy to clipboard operation
iSponsorBlockTV copied to clipboard

Allow setting device name to custom string

Open boltgolt opened this issue 2 years ago • 4 comments

When iSponsorBlockTV connects to the app the tv displays a notification that a "new device has joined", this PR makes the name that shows in that notification configurable. This is helpful for setting a more friendly name, especially handy if you have people on the network that do not know what "iSponsorBlockTV" means

boltgolt avatar Oct 17 '23 16:10 boltgolt

This is a good PR, but the use of device_name as a parameter could be confusing to users.

dmunozv04 avatar Oct 23 '23 16:10 dmunozv04

Good point, what about join_name or self_description

boltgolt avatar Oct 23 '23 16:10 boltgolt