iSponsorBlockTV icon indicating copy to clipboard operation
iSponsorBlockTV copied to clipboard
verified publisher icon dmunozv04

Added support for specifying minimum skip length

Open bourkemcrobbo opened this issue 1 year ago • 2 comments

Fixes #145

This provides support to specify minimum segment length to skip

I have no chance of updating the graphical configurator and having it work correctly, I hope the utility provided in the rest of this pull request makes up for it

bourkemcrobbo avatar Jun 10 '24 03:06 bourkemcrobbo

I have merged all changes, updated the setup to match the new format, and set default value of skip length to 0 so a user has to explicitly enable the functoinality

bourkemcrobbo avatar Jun 27 '24 04:06 bourkemcrobbo

What's the status on this? It seems to be approved but was never merged?

SuperManifolds avatar Dec 16 '24 17:12 SuperManifolds

@dmunozv04 , is there anything left for this MR? If so, I would be happy to complete any outstanding work so that this feature can get pulled in.

sternma avatar Mar 02 '25 23:03 sternma

@sternma I was never able to get the graphical configuration utility to populate the minimum skip length value. That would help complete this functionality

bourkemcrobbo avatar Mar 12 '25 04:03 bourkemcrobbo

Finished in #278. Thanks @bourkemcrobbo, I made sure to keep your commits in.

sternma avatar Mar 14 '25 23:03 sternma

Superseded by #278

dmunozv04 avatar Apr 12 '25 13:04 dmunozv04