ProtocolLib icon indicating copy to clipboard operation
ProtocolLib copied to clipboard

Holograms messed up

Open KenterWasTaken opened this issue 1 year ago • 20 comments

Describe the bug I use decent holograms and citizens on my server both on latest compatible versions, my server is running on 1.20.4 paper, and when I download protocollib and restart the server, some holograms have visible armor stands on them and some npcs (citizens) are gone and their holograms are reversed with some others, that's what happens just from downloading this plugin, is there a way to fix this, because I need it for a lot of stuff I want to add.

To Reproduce Steps to reproduce the behavior: I don't really understand this, I really just installed the plugin and it started happening.

Expected behavior Well, since it's just a dependancy for a lot of plugins, I kinda just want it to sit around and act as the dependency it is, and not disrupting my other plugins.

Screenshots None

Version Info Latest, sorry not on PC right now but I can send that later if if possible

Additional context None

KenterWasTaken avatar May 24 '24 21:05 KenterWasTaken

It isn't fixed yet!!!

KenterWasTaken avatar May 26 '24 19:05 KenterWasTaken

'Latest' is not a version... Are there any errors in console?

Jeppa avatar May 27 '24 17:05 Jeppa

@Jeppa no errors in the console.. if only it was that simple, and how is latest not a version, well if you want to be specific it's 5.2.0 the latest I believe, it's the only one that works on 1.20.4 anyway

KenterWasTaken avatar May 27 '24 17:05 KenterWasTaken

So you're on 'latest' from the project's page which is build 679. Maybe try dev build 689 . My 1.20.4 server is running decent holograms (2.8.6) and protocollib (build 678) without any issues. PS: I just have a few holograms btw. ...

Jeppa avatar May 27 '24 17:05 Jeppa

@Jeppa I'm only seeing versions such as 5.2.0, 5.1.0, and below, where are those dev builds?

KenterWasTaken avatar May 27 '24 17:05 KenterWasTaken

here https://ci.dmulloy2.net/job/ProtocolLib/ (see the Resources links on ProtocolLib's Github page (ReadMe))

Jeppa avatar May 27 '24 17:05 Jeppa

@Jeppa 689 (latest) does the same thing.. and I can't see lower than like 685 I think, what should I do? That problem is probably caused by the new versions.

KenterWasTaken avatar May 27 '24 18:05 KenterWasTaken

@Jeppa you there

KenterWasTaken avatar May 28 '24 09:05 KenterWasTaken

Still NOT fixed!!!!

KenterWasTaken avatar May 28 '24 21:05 KenterWasTaken

@Jeppa 689 (latest) does the same thing.. and I can't see lower than like 685 I think, what should I do? That problem is probably caused by the new versions.

Tested with paper/purpur 1.20.4 and DecentHolograms 2.8.8 with ProtocolLib build 689 --> no issues here! I'm not running 'citizens' on my server.

Jeppa avatar May 30 '24 18:05 Jeppa

Weird, maybe it's caused by a third-party plugin?

KenterWasTaken avatar May 30 '24 18:05 KenterWasTaken

Try to run the server without Citizens and see what happens. btw: what are the versions of citizens and DecentHolograms you are using?

Jeppa avatar May 31 '24 07:05 Jeppa

@Jeppa I tried that, definitely not citizens causing the issue, everything was the same except well the npcs. Citizens version: 2.0.33-b3382 I use decentholograms on version 2.8.8, and it's probably not caused by dh either

KenterWasTaken avatar May 31 '24 19:05 KenterWasTaken

Okay I tried removing dh from my server and the armor stands aren't caused by the holograms, they are caused by the crates, then the holograms switch with others, and the npcs dissapear and their holograms switch with others too. So it's actually causing problems to not 2 but 3 of my plugins, maybe even more that I'm not aware of.

KenterWasTaken avatar May 31 '24 19:05 KenterWasTaken

Mabe try this: you can change the config in Citizens and disable hooking into ProtocolLib: set general.interop.protocollib to false and see if this has any effect...

Jeppa avatar Jun 01 '24 10:06 Jeppa

@Jeppa alright that could really work, could I do that with the other plugins too?

KenterWasTaken avatar Jun 01 '24 10:06 KenterWasTaken

If they have a similar feature...

Jeppa avatar Jun 01 '24 11:06 Jeppa

Hello! I have the same frickig issue. PLZ FIX IT LOL Thank you. (downgrade your version @KenterWasTaken )

GitBarna avatar Jan 01 '25 14:01 GitBarna

same issue still not fixed but I caused it by mistake, it happens when you crease a protocol lib listener for entities, even though the listener does literally nothing.

Image

LuxCubeX avatar Feb 11 '25 04:02 LuxCubeX

ahh turns out it is when any of your plugins has a listener for SPAWN_ENTITY with protocollib, even if the method does nothing just making the listener.

So if you have control over the source code of the specific plugin that does that and you know how to code, you'll have to make it work with PlayerShowEntityEvent instead, even though you probably won't do your thing properly till it gets fixed.

LuxCubeX avatar Feb 11 '25 04:02 LuxCubeX