PacketWrapper icon indicating copy to clipboard operation
PacketWrapper copied to clipboard

What's the recommended way to use?

Open ShayBox opened this issue 5 years ago • 1 comments

Should you use the official maven repo, jitpack, or local build and shadow it into your jar, or copy the entire project into your project, and if the latter, should you include everything, or go through and copy only the things you use, also should you keep the package path the same or change it to avoid conflicting with other plugins that include it.

I've found plugins doing all of this, even a plugin that modified this into a plugin and had the user install it in their server's plugin folder, so which one is recommended by you, Thanks.

EDIT: Unrelated but WrapperPlayServerCustomPayload and WrapperPlayClientCustomPayload getContents() is modifying the original data, causing the data to be deleted when using the method, use .copy() on the buffer.

ShayBox avatar Jul 11 '20 06:07 ShayBox

It's recommended to copy the classes you need into your project

dmulloy2 avatar Jul 26 '20 04:07 dmulloy2