odiff icon indicating copy to clipboard operation
odiff copied to clipboard

Reduce size of npm package

Open eWert-Online opened this issue 3 years ago • 5 comments

I recently investigated why the size of the package is that big and found out, that we include a lot of unnecessary stuff. It also seems like esy includes the RunTests.exe in the release build.

Things that can be removed from the package:

  • [x] ~odiff-Linux-xxx.tar.gz~
  • [x] ~odiff-MacOS-xxx.tar.gz~
  • [x] ~odiff-Windows_x64-xxx.tar.gz~
  • [ ] RunTests.exe

eWert-Online avatar Jul 01 '21 09:07 eWert-Online

I am not publishing them on npm https://www.jsdelivr.com/package/npm/odiff-bin I left them to publish as assets to GitHub release (I know one team that are using raw binaries to run odiff)

dmtrKovalenko avatar Jul 01 '21 09:07 dmtrKovalenko

Ah I see! But the RunTests.exe is something which could be removed, right?

eWert-Online avatar Jul 01 '21 10:07 eWert-Online

Is it there?

dmtrKovalenko avatar Jul 01 '21 10:07 dmtrKovalenko

Yes, in the bin folder after you install it. So it seems to be packaged by esy

Bildschirmfoto 2021-07-01 um 13 19 58

eWert-Online avatar Jul 01 '21 11:07 eWert-Online

Hmmm it is weird, I thought "includePackages": [ "odiff" ] should do the trick but yeah we should not add this to the binary

dmtrKovalenko avatar Jul 01 '21 11:07 dmtrKovalenko