dmtcp icon indicating copy to clipboard operation
dmtcp copied to clipboard

"dmtcp_coordinator" segmentation fault if running executable from `make install` in Release 2.6

Open LouisJenkinsCS opened this issue 4 years ago • 1 comments

When running dmtcp_coordinator from make install it will result in a segmentation fault. When analyzing the core dump, it shows that it crashes because base_argv0 has the value 0x1 due to it trying to separate the forward slash characters ('/'). The reason it does not get stopped by the NULL check seems to be the fact that strrchr(argv0_copy, '/') /* 0x0 */ + 1 /* 0x1 */ != NULL /* 0x0 */.

This has been patched out in the current master branch

https://github.com/dmtcp/dmtcp/blob/f888833eebec23a743d954f5df3107d5c416953c/src/dmtcp_coordinator.cpp#L1540-L1541

But it is not in the 2.6 branch

https://github.com/dmtcp/dmtcp/blob/d0cec6b2ce32201e6b4de6a478d3f3f4032ac121/src/dmtcp_coordinator.cpp#L1538-L1539

Perhaps this can be added to it given that 2.6.1 is not yet released?

LouisJenkinsCS avatar Jan 10 '22 15:01 LouisJenkinsCS

Thanks, @LouisJenkinsCS for pointing it out.

@gc00 since you merge #905 PR into master, could you also add the PR to other branches (2.6 and 2.5)?

--Twinkle

JainTwinkle avatar Jan 12 '22 00:01 JainTwinkle