fastapi_client icon indicating copy to clipboard operation
fastapi_client copied to clipboard

Custom httpx.AsyncClient kwargs usage

Open ivasio opened this issue 3 years ago • 1 comments

Hi! Thanks a lot for the project!

I'm trying to generate a client lib using this tool and I'm facing some issues, specifically with setting custom headers for the request. I don't have any experience using httpx so far, but looks like setting these headers when instantiating httpx.AsyncClient and using them afterwards makes perfect sense. But for some reason at https://github.com/dmontagu/fastapi_client/blob/master/openapi-python-templates/api_client.mustache#L56 httpx.Request is instantiated directly and no headers are proxied from httpx.AsyncClient. Using self._async_client.build_request at this line has solved the problem and I'd like to pull request it

Is there anything wrong with it? Or I can pull request?

ivasio avatar May 05 '21 11:05 ivasio

bump.

This issue makes the generated code unusable for any API involving headers authentication. (without code modification ofc).

@ivasio I can open up the PR unless you've already got one / wanted to handle it.

Thanks for pointing out a fix, very helpful :slightly_smiling_face:

colindjk avatar Jul 06 '21 21:07 colindjk