Kevin Jahns comments

Results 261 comments of


                                             Kevin Jahns

Add option for human readable key encoding

Sure, feel free to open a PR :+1:

Cannot read properties of `null` when `yArray.push([yDoc.getMap('x')])`

A shared type can only exist once in a document. It can't exist both as the root-level type and as a child element of another shared type. The documentation explains...

Reconnected client becomes visible to others only after some period

That's a good point. Thank you, I'll look into this!

Contents permissions and RTC

In Yjs, it's not possible to accept some changes and discard others. However, you can make a distinction between read-only clients (discard their updates on the backend) and read-write clients....

Fix YJS UndoManager .stopCapturing being ignored when captureTimeout above unix timestamp

@PatrickShaw Thanks for this

Remove modeldb

This PR is ready for review. > I see a lot of calls like ...model.sharedModel... (eg editor.model.sharedModel.getSource()). At some point, we could think to add shortcut methods to get rid...

Remove modeldb

Thank you for the feedback @SylvainCorlay. > The hierarchy of cell types do not match the schemas. For example, the base YCell already has attributes such as attachments, which don't...

Remove modeldb

@afshin Thanks, but I suggest that we merge this PR as-is as it is a general improvement. That is, unless there are issues that somebody found after a review. We...

Remove modeldb

I rebased and made a quick usability check (checking whether collaboration still works). Let's wait for the tests to succeed.

Remove modeldb

Thanks for checking @echarles. I just tried that out again and it does work for me. I collaborated in two different browsers and I didn't notice any error messages. Can...